test(analytics): migrate confirmations and PPOM metrics E2E#43440
test(analytics): migrate confirmations and PPOM metrics E2E#43440gauthierpetetin wants to merge 1 commit into
Conversation
c5f6887 to
6a2ae2e
Compare
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [6a2ae2e]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 6 warn · 🔴 1 fail)
Bundle size diffs
|
6a2ae2e to
eeb9e9f
Compare
Builds ready [eeb9e9f]
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 5 warn · 🔴 0 fail)
Bundle size diffs
|
eeb9e9f to
7236460
Compare
Builds ready [7236460] [reused from eeb9e9f]
⚡ Performance Benchmarks (Total: 🟢 19 pass · 🟡 5 warn · 🔴 0 fail)
Bundle size diffs
|
Refresh slice from main-synced monolithic branch.
7236460 to
71df8b2
Compare
Builds ready [71df8b2] [reused from 24c31c1]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 10 warn · 🔴 2 fail)
Bundle size diffs
|
There was a problem hiding this comment.
Pull request overview
This PR updates MetaMask Extension E2E specs for confirmations and PPOM so they no longer rely on legacy MetaMetrics fixture fields, and instead use the canonical analytics consent/ID fields introduced in the Analytics Phase B migration.
Changes:
- Updated E2E fixture setup to use
analyticsId,optedIn, andcompletedMetaMetricsOnboardinginstead ofmetaMetricsId/participateInMetaMetrics. - Updated Segment event assertions in PPOM E2E specs to expect
userId: MOCK_ANALYTICS_ID. - Replaced imports/usages of
MOCK_META_METRICS_IDwithMOCK_ANALYTICS_IDin affected confirmations + PPOM specs/helpers.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/tests/ppom/ppom-blockaid-toggle-metrics.spec.ts | Migrates PPOM toggle metrics test fixture + expected userId to canonical analytics fields. |
| test/e2e/tests/ppom/ppom-blockaid-alert-metrics.spec.js | Migrates PPOM alert metrics test fixture + expected userId to canonical analytics fields. |
| test/e2e/tests/confirmations/transactions/metrics.spec.ts | Updates confirmations transaction metrics fixture to use canonical analytics fields. |
| test/e2e/tests/confirmations/navigation.spec.ts | Updates confirmations navigation fixture to use canonical analytics fields. |
| test/e2e/tests/confirmations/helpers.ts | Updates shared confirmations fixture helpers to use canonical analytics fields. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Part 12 of the Analytics Phase B split (supersedes monolithic #43406).
Owner: @MetaMask/confirmations
Reason: Confirmations and PPOM metrics E2E specs still use legacy metrics fixture fields.
Solution: Update confirmations and PPOM metrics E2E specs for canonical analytics fields.
Depends on: #43430
Changelog
CHANGELOG entry: null
Related issues
Part of https://github.com/MetaMask/MetaMask-planning/issues/7331
Manual testing steps
yarn build:testPre-merge author checklist
Pre-merge reviewer checklist