Skip to content

refactor: migrate private-key list and connect page#43482

Draft
gantunesr wants to merge 1 commit into
mainfrom
gar/refactor/mul-1880
Draft

refactor: migrate private-key list and connect page#43482
gantunesr wants to merge 1 commit into
mainfrom
gar/refactor/mul-1880

Conversation

@gantunesr

Copy link
Copy Markdown
Member

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mm-token-exchange-service

Copy link
Copy Markdown

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (4 files, +159 -103)
  • 📁 ui/
    • 📁 components/
      • 📁 multichain-accounts/
        • 📁 multichain-private-key-list/
          • 📄 multichain-private-key-list.tsx +9 -10
    • 📁 pages/
      • 📁 multichain-accounts/
        • 📁 multichain-accounts-connect-page/
          • 📁 __snapshots__/
            • 📄 multichain-accounts-connect-page.test.tsx.snap +111 -45
            • 📄 multichain-accounts-connect-page.test.tsx +5 -7
            • 📄 multichain-accounts-connect-page.tsx +34 -41

@metamaskbotv2

metamaskbotv2 Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
Builds ready [3a54e26]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 6 warn · 🔴 2 fail)

Baseline (latest main): ae7f0e0 | Date: 6/11/2026 | Pipeline: 27389679290 | Baseline logs

Metricschrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 inp(p95) [CI log]🔴 load_new_account(p95) [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 2 failures)

Interaction Benchmarks · Samples: 5 🔴 1
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]🔴 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -19%
  • loadNewAccount/total: -19%
  • loadNewAccount/inp: +23%
  • loadNewAccount/fcp: +14%
  • loadNewAccount/lcp: -65%
  • bridgeUserActions/bridge_load_page: +33%
  • bridgeUserActions/bridge_load_asset_picker: -23%
  • bridgeUserActions/longTaskCount: +100%
  • bridgeUserActions/longTaskTotalDuration: +68%
  • bridgeUserActions/longTaskMaxDuration: +15%
  • bridgeUserActions/tbt: +52%
  • loadNewAccount/load_new_account: +400%
  • loadNewAccount/total: +400%
  • loadNewAccount/inp: -35%
  • loadNewAccount/fcp: -51%
  • loadNewAccount/lcp: +373%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/fcp: -50%
  • confirmTx/lcp: +1167%
  • bridgeUserActions/bridge_load_page: +77%
  • bridgeUserActions/bridge_load_asset_picker: +22%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/inp: -18%
  • bridgeUserActions/fcp: -46%
  • bridgeUserActions/lcp: +1068%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/inp: -11%
  • startupPowerUserHome/longTaskMaxDuration: +12%
  • startupPowerUserHome/inp: +11%
  • startupPowerUserHome/backgroundConnect: +41%
  • startupPowerUserHome/setupStore: +19%
  • startupPowerUserHome/fcp: +17%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 592ms
  • 🟡 startupPowerUserHome/INP: p75 208ms
  • 🟡 startupPowerUserHome/LCP: p75 3.2s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/doneButtonToHomeScreen: -89%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
  • onboardingImportWallet/longTaskCount: -72%
  • onboardingImportWallet/longTaskTotalDuration: -88%
  • onboardingImportWallet/longTaskMaxDuration: -81%
  • onboardingImportWallet/tbt: -95%
  • onboardingImportWallet/total: -88%
  • onboardingNewWallet/skipBackupToMetricsScreen: +12%
  • onboardingNewWallet/doneButtonToAssetList: -47%
  • onboardingNewWallet/longTaskCount: -44%
  • onboardingNewWallet/longTaskTotalDuration: -58%
  • onboardingNewWallet/longTaskMaxDuration: -28%
  • onboardingNewWallet/tbt: -68%
  • onboardingNewWallet/total: -41%
  • solanaAssetDetails/assetClickToPriceChart: +97%
  • solanaAssetDetails/total: +97%
  • solanaAssetDetails/inp: -40%
  • solanaAssetDetails/lcp: -13%
  • solanaAssetDetails/cls: -92%
  • importSrpHome/loginToHomeScreen: -23%
  • importSrpHome/openAccountMenuAfterLogin: +35%
  • importSrpHome/homeAfterImportWithNewWallet: -40%
  • importSrpHome/longTaskCount: -40%
  • importSrpHome/longTaskTotalDuration: -39%
  • importSrpHome/longTaskMaxDuration: -19%
  • importSrpHome/tbt: -45%
  • importSrpHome/total: -36%
  • importSrpHome/inp: -29%
  • sendTransactions/openSendPageFromHome: +15%
  • sendTransactions/selectTokenToSendFormLoaded: +15%
  • sendTransactions/inp: -19%
  • sendTransactions/cls: -90%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 2.0s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.8s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -326 Bytes (0%)
  • common: 20 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant