feat(ledger): implement DMK offscreen handler and dependencies#43489
feat(ledger): implement DMK offscreen handler and dependencies#43489montelaidev wants to merge 1 commit into
Conversation
Replace the DMK stub with the full LedgerDMKBridgeHandler backed by @metamask/eth-ledger-bridge-keyring preview and Ledger DMK packages. Adds EIP-7702 delegation signing, bridge wiring, UI adapter updates, and unit tests with Jest-compatible mocks for ESM-only transport packages. Co-authored-by: Cursor <cursoragent@cursor.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (5 files, +1006 -25)
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution MetaMask internal reviewing guidelines:
|
Description
Implements the real Ledger DMK (
Device Management Kit) offscreen handler, replacing the PR 1 stub that delegated to legacy.PR 3 of 3 (stacked on #43488):
ledgerDmkfeature flag + runtime mode switching (feat(ledger): wire ledgerDmk flag to offscreen mode switching #43488)Changes:
LedgerDMKBridgeHandlerwith session lifecycle, device discovery, and action routing@metamask/eth-ledger-bridge-keyringplus Ledger DMK packagesgetLedgerModeUI action,LedgerAdapter/ RPC error utils updates@ledgerhq/device-transport-kit-web-hid)Changelog Entry
CHANGELOG entry: null
Related Issues
Fixes: N/A
Manual Testing Steps
ledgerDmkvia.manifest-overrides.json(see PR 2 instructions) or LaunchDarkly.yarn build:testrecommended for LavaMoat parity).ledgerDmkoff and confirm legacy handler still works.Pre-merge Author Checklist
Made with Cursor