You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Note
Medium Risk
Changes ride through multichain RPC middleware and chain-agnostic permission handling (dapp-facing, permission-sensitive) without local code review in this repo; regression risk is mainly in connect/RPC behavior for execution permissions.
Overview
Bumps @metamask/chain-agnostic-permission to 1.6.2 and @metamask/multichain-api-middleware to 3.1.4 in package.json, with matching yarn.lock updates (including @metamask/api-specs 0.15.0 and refreshed transitive MetaMask core deps). There are no extension source changes in this PR.
The intent is to pull in upstream support so ERC-7715 / wallet_*ExecutionPermissions RPCs work over the Multichain API and MetaMask Connect (e.g. wallet_getSupportedExecutionPermissions appearing for connected EVM scopes).
Reviewed by Cursor Bugbot for commit 2a73e44. Bugbot is set up for automated code reviews on this repo. Configure here.
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables ERC-7715 requests over the Multichain API and MetaMask Connect with the following changes:
chain-agnostic-permissionsto1.6.2multichain-api-middlewareto3.1.4Changelog
CHANGELOG entry: Enabled ERC-7715 requests over the Multichain API and MetaMask Connect
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-1548
Manual testing steps
wallet_getSupportedExecutionPermissionsand invoke itScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes ride through multichain RPC middleware and chain-agnostic permission handling (dapp-facing, permission-sensitive) without local code review in this repo; regression risk is mainly in connect/RPC behavior for execution permissions.
Overview
Bumps
@metamask/chain-agnostic-permissionto 1.6.2 and@metamask/multichain-api-middlewareto 3.1.4 inpackage.json, with matchingyarn.lockupdates (including@metamask/api-specs0.15.0 and refreshed transitive MetaMask core deps). There are no extension source changes in this PR.The intent is to pull in upstream support so ERC-7715 /
wallet_*ExecutionPermissionsRPCs work over the Multichain API and MetaMask Connect (e.g.wallet_getSupportedExecutionPermissionsappearing for connected EVM scopes).Reviewed by Cursor Bugbot for commit 2a73e44. Bugbot is set up for automated code reviews on this repo. Configure here.