perf: reuse canonical deep link URL for verification#43520
Draft
davidmurdoch wants to merge 1 commit into
Draft
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
||
| const signature = await verify(url); | ||
| const signatureStr = url.searchParams.get(SIG_PARAM); | ||
| const signature = signatureStr |
Builds ready [90614fc]
⚡ Performance Benchmarks (Total: 🟢 14 pass · 🟡 11 warn · 🔴 0 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reuses the canonical deep-link URL across parsing and signature verification so signed links avoid canonicalizing the same URL twice. This also narrows
verifyso callers pass the required signature and the already-canonical URL directly.This implements the optimization discussed in #37086 (comment).
Changelog
CHANGELOG entry: null
Related issues
Fixes: N/A
Manual testing steps
yarn test:unit shared/lib/deep-links- passedyarn lint:changed:fix- passedyarn lint:tsc- failed on existing repo-wide missing packages/type errors; no changed files were reportedPre-merge author checklist
Pre-merge reviewer checklist