Skip to content

perf(6630): memoize Context Provider Values for Notifications, RiveWasm and GasFee#43525

Open
DDDDDanica wants to merge 1 commit into
mainfrom
perf/6637-RiveWasm
Open

perf(6630): memoize Context Provider Values for Notifications, RiveWasm and GasFee#43525
DDDDDanica wants to merge 1 commit into
mainfrom
perf/6637-RiveWasm

Conversation

@DDDDDanica

Copy link
Copy Markdown
Contributor

Description

3 context providers pass inline object literals as value, causing all consumers to re-render on every provider render, even when values haven't changed.

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6637, https://github.com/MetaMask/MetaMask-planning/issues/6639, https://github.com/MetaMask/MetaMask-planning/issues/6641

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service

Copy link
Copy Markdown

✨ Files requiring CODEOWNER review ✨

🔔 @MetaMask/notifications (1 files, +16 -5)
  • 📁 ui/
    • 📁 contexts/
      • 📁 metamask-notifications/
        • 📄 metamask-notifications.tsx +16 -5

@mm-token-exchange-service

Copy link
Copy Markdown
Builds ready [631b9e9]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 8 warn · 🔴 0 fail)

Baseline (latest main): c649761 | Date: 6/12/2026 | Pipeline: 27444999745 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/lcp: -13%
  • confirmTx/lcp: -17%
  • bridgeUserActions/inp: -18%
  • loadNewAccount/load_new_account: +70%
  • loadNewAccount/total: +70%
  • loadNewAccount/inp: +35%
  • loadNewAccount/fcp: -46%
  • loadNewAccount/lcp: +1122%
  • confirmTx/confirm_tx: +10%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +10%
  • confirmTx/inp: +10%
  • confirmTx/fcp: -46%
  • confirmTx/lcp: +1104%
  • bridgeUserActions/bridge_load_page: +98%
  • bridgeUserActions/bridge_load_asset_picker: +61%
  • bridgeUserActions/bridge_search_token: +21%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +51%
  • bridgeUserActions/inp: -25%
  • bridgeUserActions/lcp: +1181%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/inp: -11%
  • startupPowerUserHome/backgroundConnect: +12%
  • startupPowerUserHome/setupStore: +10%
  • startupPowerUserHome/numNetworkReqs: -24%
  • startupPowerUserHome/tbt: +11%
  • startupStandardHome/domInteractive: +18%
  • startupStandardHome/setupStore: +14%
  • startupStandardHome/fcp: +14%
  • startupPowerUserHome/domInteractive: -22%
  • startupPowerUserHome/setupStore: +18%
  • startupPowerUserHome/fcp: -19%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 528ms
  • 🟡 startupPowerUserHome/LCP: p75 2.7s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/doneButtonToHomeScreen: -87%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
  • onboardingImportWallet/longTaskCount: -77%
  • onboardingImportWallet/longTaskTotalDuration: -93%
  • onboardingImportWallet/longTaskMaxDuration: -90%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -85%
  • onboardingNewWallet/doneButtonToAssetList: -22%
  • onboardingNewWallet/longTaskTotalDuration: -40%
  • onboardingNewWallet/longTaskMaxDuration: -20%
  • onboardingNewWallet/tbt: -51%
  • onboardingNewWallet/total: -20%
  • solanaAssetDetails/assetClickToPriceChart: -58%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -58%
  • solanaAssetDetails/cls: -89%
  • importSrpHome/loginToHomeScreen: -31%
  • importSrpHome/openAccountMenuAfterLogin: +164%
  • importSrpHome/homeAfterImportWithNewWallet: -41%
  • importSrpHome/longTaskCount: -22%
  • importSrpHome/longTaskTotalDuration: -36%
  • importSrpHome/longTaskMaxDuration: -21%
  • importSrpHome/tbt: -47%
  • importSrpHome/total: -37%
  • importSrpHome/inp: -13%
  • importSrpHome/lcp: +12%
  • sendTransactions/openSendPageFromHome: -17%
  • sendTransactions/inp: -19%
  • sendTransactions/lcp: -12%
  • sendTransactions/cls: -88%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 224ms
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 2.0s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -118 Bytes (0%)
  • common: 20 Bytes (0%)

@mm-token-exchange-service

Copy link
Copy Markdown
Builds ready [92bf578]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 7 warn · 🔴 1 fail)

Baseline (latest main): c649761 | Date: 6/12/2026 | Pipeline: 27448086258 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
🔴 bridge_search_token

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/inp: +15%
  • confirmTx/inp: -10%
  • confirmTx/lcp: -14%
  • bridgeUserActions/inp: -25%
  • loadNewAccount/load_new_account: +66%
  • loadNewAccount/total: +66%
  • loadNewAccount/lcp: +1076%
  • confirmTx/confirm_tx: +10%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +10%
  • confirmTx/inp: +50%
  • confirmTx/fcp: -50%
  • confirmTx/lcp: +1086%
  • bridgeUserActions/bridge_load_page: +65%
  • bridgeUserActions/bridge_load_asset_picker: +104%
  • bridgeUserActions/bridge_search_token: +283%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +233%
  • bridgeUserActions/inp: -33%
  • bridgeUserActions/fcp: -51%
  • bridgeUserActions/lcp: +1129%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/numNetworkReqs: -26%
  • startupPowerUserHome/longTaskMaxDuration: +10%
  • startupPowerUserHome/inp: +13%
  • startupPowerUserHome/domInteractive: -17%
  • startupPowerUserHome/backgroundConnect: -53%
  • startupPowerUserHome/setupStore: +15%
  • startupPowerUserHome/fcp: -16%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 568ms
  • 🟡 startupPowerUserHome/LCP: p75 2.8s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/srpButtonToSrpForm: +12%
  • onboardingImportWallet/confirmSrpToPwForm: +11%
  • onboardingImportWallet/pwFormToMetricsScreen: +11%
  • onboardingImportWallet/doneButtonToHomeScreen: -86%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -96%
  • onboardingImportWallet/longTaskCount: -77%
  • onboardingImportWallet/longTaskTotalDuration: -92%
  • onboardingImportWallet/longTaskMaxDuration: -88%
  • onboardingImportWallet/tbt: -97%
  • onboardingImportWallet/total: -84%
  • onboardingNewWallet/skipBackupToMetricsScreen: +11%
  • onboardingNewWallet/doneButtonToAssetList: -22%
  • onboardingNewWallet/longTaskTotalDuration: -32%
  • onboardingNewWallet/longTaskMaxDuration: -23%
  • onboardingNewWallet/tbt: -68%
  • onboardingNewWallet/total: -18%
  • solanaAssetDetails/assetClickToPriceChart: -47%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -47%
  • solanaAssetDetails/cls: -89%
  • importSrpHome/loginToHomeScreen: -23%
  • importSrpHome/openAccountMenuAfterLogin: +13%
  • importSrpHome/homeAfterImportWithNewWallet: -39%
  • importSrpHome/longTaskCount: -22%
  • importSrpHome/longTaskTotalDuration: -33%
  • importSrpHome/longTaskMaxDuration: -22%
  • importSrpHome/tbt: -34%
  • importSrpHome/total: -36%
  • importSrpHome/inp: -28%
  • sendTransactions/openSendPageFromHome: +172%
  • sendTransactions/selectTokenToSendFormLoaded: +45%
  • sendTransactions/inp: -32%
  • sendTransactions/cls: -88%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: -118 Bytes (0%)
  • common: 20 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant