fix: value transfers parsing cp-13.36.0#43528
Open
n3ps wants to merge 2 commits into
Open
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mm-token-exchange-service
Bot
added
the
team-core-extension-ux
n3ps
commented
Jun 13, 2026
| ({ to, transferType }) => | ||
| equalsIgnoreCase(to, subjectAddress) && isNftStandard(transferType), | ||
| ); | ||
| const { |
n3ps
commented
Jun 13, 2026
| '0x0000000000000000000000000000000000000000', | ||
| 'eip155:59144', | ||
| ), | ||
| symbol: 'ETH', |
Contributor
Author
There was a problem hiding this comment.
Point of interest: correct destination token, not dust
n3ps
changed the title
Builds ready [4419f23]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 1 fail)
Bundle size diffs
|
Builds ready [69319ba]
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs
|
n3ps
commented
Jun 15, 2026
|
|
||
| function getDefinedArgs(...args: (string | undefined)[]) { | ||
| return args.filter((arg) => Boolean(arg)); | ||
| return args.map((arg) => arg ?? ''); |
Contributor
Author
There was a problem hiding this comment.
to avoid rendering the locale message placeholder "$"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the swap activity item destination token for API responses with multiple value transfers
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist