Skip to content

fix: Correct SnapUIFooterButton text color#43539

Merged
FrederikBolding merged 1 commit into
mainfrom
fb/fix-snap-footer-button-color
Jun 15, 2026
Merged

fix: Correct SnapUIFooterButton text color#43539
FrederikBolding merged 1 commit into
mainfrom
fb/fix-snap-footer-button-color

Conversation

@FrederikBolding

Copy link
Copy Markdown
Member

Description

The SnapUIFooterButton text color drifted at some point recently, this PR fixes that.

Changelog

CHANGELOG entry: null

Screenshots/Recordings

Before

Screenshot 2026-06-15 at 10 55 07

After

Screenshot 2026-06-15 at 10 52 44

@FrederikBolding FrederikBolding requested a review from a team as a code owner June 15, 2026 08:56
@mm-token-exchange-service mm-token-exchange-service Bot added the team-core-platform Core Platform team label Jun 15, 2026
@mm-token-exchange-service

Copy link
Copy Markdown

✨ Files requiring CODEOWNER review ✨

🫰 @MetaMask/core-platform (1 files, +1 -1)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 snaps/
          • 📁 snap-ui-footer-button/
            • 📄 index.scss +1 -1

@mm-token-exchange-service mm-token-exchange-service Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 15, 2026
@mm-token-exchange-service

Copy link
Copy Markdown
Builds ready [1f8b5fc]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 10 warn · 🔴 0 fail)

Baseline (latest main): 5682526 | Date: 6/13/2026 | Pipeline: 27535235086 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/inp: +18%
  • confirmTx/lcp: -12%
  • bridgeUserActions/bridge_load_page: -24%
  • bridgeUserActions/inp: -32%
  • loadNewAccount/load_new_account: +76%
  • loadNewAccount/total: +76%
  • loadNewAccount/inp: -12%
  • loadNewAccount/lcp: +1077%
  • confirmTx/confirm_tx: +13%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +13%
  • confirmTx/inp: +30%
  • confirmTx/fcp: +10%
  • confirmTx/lcp: +1095%
  • bridgeUserActions/bridge_load_page: +54%
  • bridgeUserActions/bridge_load_asset_picker: +109%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +195%
  • bridgeUserActions/inp: -32%
  • bridgeUserActions/fcp: -52%
  • bridgeUserActions/lcp: +1133%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/numNetworkReqs: +22%
  • startupPowerUserHome/inp: +14%
  • startupStandardHome/uiStartup: -19%
  • startupStandardHome/load: -19%
  • startupStandardHome/domContentLoaded: -19%
  • startupStandardHome/domInteractive: -47%
  • startupStandardHome/backgroundConnect: -15%
  • startupStandardHome/firstReactRender: -19%
  • startupStandardHome/loadScripts: -20%
  • startupStandardHome/setupStore: -17%
  • startupStandardHome/fcp: -44%
  • startupStandardHome/lcp: -20%
  • startupPowerUserHome/backgroundConnect: -29%
  • startupPowerUserHome/setupStore: +17%
  • startupPowerUserHome/numNetworkReqs: -11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 560ms
  • 🟡 startupPowerUserHome/LCP: p75 2.7s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: +14%
  • onboardingImportWallet/doneButtonToHomeScreen: -87%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
  • onboardingImportWallet/longTaskCount: -77%
  • onboardingImportWallet/longTaskTotalDuration: -92%
  • onboardingImportWallet/longTaskMaxDuration: -89%
  • onboardingImportWallet/tbt: -98%
  • onboardingImportWallet/total: -84%
  • onboardingNewWallet/doneButtonToAssetList: -35%
  • onboardingNewWallet/longTaskCount: -55%
  • onboardingNewWallet/longTaskTotalDuration: -62%
  • onboardingNewWallet/longTaskMaxDuration: -35%
  • onboardingNewWallet/tbt: -73%
  • onboardingNewWallet/total: -31%
  • solanaAssetDetails/assetClickToPriceChart: -52%
  • solanaAssetDetails/longTaskCount: -100%
  • solanaAssetDetails/longTaskTotalDuration: -100%
  • solanaAssetDetails/longTaskMaxDuration: -100%
  • solanaAssetDetails/tbt: -100%
  • solanaAssetDetails/total: -52%
  • solanaAssetDetails/lcp: +11%
  • solanaAssetDetails/cls: -89%
  • importSrpHome/loginToHomeScreen: -12%
  • importSrpHome/openAccountMenuAfterLogin: +34%
  • importSrpHome/homeAfterImportWithNewWallet: -39%
  • importSrpHome/longTaskCount: -31%
  • importSrpHome/longTaskTotalDuration: -40%
  • importSrpHome/longTaskMaxDuration: -12%
  • importSrpHome/tbt: -47%
  • importSrpHome/total: -35%
  • importSrpHome/inp: -32%
  • sendTransactions/openSendPageFromHome: +23%
  • sendTransactions/inp: -30%
  • sendTransactions/cls: -89%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.8s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@FrederikBolding FrederikBolding added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit 928869e Jun 15, 2026
206 of 209 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-snap-footer-button-color branch June 15, 2026 10:07
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
@metamaskbot metamaskbot added the release-13.37.0 Issue or pull request that will be included in release 13.37.0 label Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-13.37.0 Issue or pull request that will be included in release 13.37.0 team-core-platform Core Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants