fix: non evm bridge activity type cp-13-36.0 by n3ps · Pull Request #43557 · MetaMask/metamask-extension

n3ps · 2026-06-15T15:16:02Z

Description

Keyring transactions mark these as "send" and need a lookup to render as a bridge activity

Fixes #43498

Note: activity redesign is behind a flag

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2026-06-15T15:16:19Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

mm-token-exchange-service · 2026-06-15T15:16:30Z

✨ Files requiring CODEOWNER review ✨

🔄 @MetaMask/swaps-engineers (1 files, +1 -1)

📁 ui/
- 📁 ducks/
  - 📁 bridge-status/
    - 📄 selectors.ts +1 -1

n3ps · 2026-06-15T15:19:34Z

    selectNonEvmTransactionsForActivity,
    getAssetsMetadata,
    getInternalAccountsObject,
+    selectBridgeHistoryItem,


include the bridge item, if existing

n3ps · 2026-06-15T15:19:54Z

+      const bridgeStatus = bridgeHistory.status.status;
+
+      return {
+        type: 'bridge',


then map accordingly

mm-token-exchange-service · 2026-06-15T15:48:13Z

Builds ready [89595b0]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
Webpack builds: chrome, firefox
Webpack builds (beta): chrome, firefox
Webpack builds (flask): chrome, firefox
Webpack builds (test): chrome, firefox
Webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

Deprecated Browserify fallback builds

Browserify builds: chrome, firefox
Browserify builds (beta): chrome, firefox
Browserify builds (flask): chrome, firefox
Browserify builds (test): chrome, firefox
Browserify builds (test-flask): chrome, firefox

⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 6 warn · 🔴 0 fail)

Baseline (latest main): 979f290 | Date: 6/15/2026 | Pipeline: 27556428415 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-webpack firefox-webpack
loadNewAccount
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
bridgeUserActions
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
🟡 bridge_search_token

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/inp: -10%
↓ confirmTx/inp: -12%
↓ confirmTx/lcp: -63%
↑ bridgeUserActions/bridge_load_asset_picker: +23%
↓ bridgeUserActions/inp: -15%
↑ loadNewAccount/load_new_account: +619%
↑ loadNewAccount/total: +619%
↓ loadNewAccount/inp: -10%
↓ loadNewAccount/fcp: -48%
↑ loadNewAccount/lcp: +1053%
↓ confirmTx/longTaskCount: -100%
↓ confirmTx/longTaskTotalDuration: -100%
↓ confirmTx/longTaskMaxDuration: -100%
↓ confirmTx/tbt: -100%
↓ confirmTx/inp: -12%
↓ confirmTx/fcp: -44%
↑ confirmTx/lcp: +347%
↑ bridgeUserActions/bridge_load_page: +94%
↑ bridgeUserActions/bridge_load_asset_picker: +293%
↑ bridgeUserActions/bridge_search_token: +194%
↓ bridgeUserActions/longTaskCount: -100%
↓ bridgeUserActions/longTaskTotalDuration: -100%
↓ bridgeUserActions/longTaskMaxDuration: -100%
↓ bridgeUserActions/tbt: -100%
↑ bridgeUserActions/total: +193%
↓ bridgeUserActions/fcp: -46%
↑ bridgeUserActions/lcp: +1190%

Startup Benchmarks · Samples: 100

Benchmark chrome-webpack firefox-webpack
startupStandardHome
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]

📈 Results compared to the previous 5 runs on main
↑ startupStandardHome/uiStartup: +10%
↑ startupStandardHome/load: +11%
↑ startupStandardHome/domContentLoaded: +11%
↑ startupStandardHome/domInteractive: +11%
↑ startupStandardHome/firstPaint: +17%
↑ startupStandardHome/backgroundConnect: +14%
↑ startupStandardHome/loadScripts: +11%
↑ startupStandardHome/setupStore: +10%
↑ startupStandardHome/longTaskTotalDuration: +11%
↑ startupStandardHome/longTaskMaxDuration: +11%
↑ startupStandardHome/tbt: +13%
↑ startupStandardHome/fcp: +13%
↓ startupStandardHome/lcp: -15%
↑ startupPowerUserHome/domInteractive: +10%
↑ startupPowerUserHome/backgroundConnect: +45%
↑ startupPowerUserHome/setupStore: +11%
↓ startupPowerUserHome/numNetworkReqs: -14%
↑ startupPowerUserHome/inp: +19%
↓ startupPowerUserHome/fcp: -12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 528ms
🟡 startupPowerUserHome/INP: p75 224ms
🟡 startupPowerUserHome/LCP: p75 2.7s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-webpack firefox-webpack
onboardingImportWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
assetDetails
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
importSrpHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
sendTransactions
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
swap
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/metricsToWalletReadyScreen: -22%
↓ onboardingImportWallet/doneButtonToHomeScreen: -88%
↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
↓ onboardingImportWallet/longTaskCount: -80%
↓ onboardingImportWallet/longTaskTotalDuration: -94%
↓ onboardingImportWallet/longTaskMaxDuration: -91%
↓ onboardingImportWallet/tbt: -98%
↓ onboardingImportWallet/total: -87%
↓ onboardingNewWallet/doneButtonToAssetList: -16%
↓ onboardingNewWallet/longTaskCount: -55%
↓ onboardingNewWallet/longTaskTotalDuration: -37%
↓ onboardingNewWallet/longTaskMaxDuration: -34%
↓ onboardingNewWallet/tbt: -73%
↓ onboardingNewWallet/total: -14%
↓ solanaAssetDetails/assetClickToPriceChart: -70%
↓ solanaAssetDetails/longTaskCount: -100%
↓ solanaAssetDetails/longTaskTotalDuration: -100%
↓ solanaAssetDetails/longTaskMaxDuration: -100%
↓ solanaAssetDetails/tbt: -100%
↓ solanaAssetDetails/total: -70%
↑ solanaAssetDetails/inp: +18%
↓ solanaAssetDetails/cls: -90%
↓ importSrpHome/loginToHomeScreen: -16%
↑ importSrpHome/openAccountMenuAfterLogin: +101%
↓ importSrpHome/homeAfterImportWithNewWallet: -42%
↓ importSrpHome/longTaskCount: -33%
↓ importSrpHome/longTaskTotalDuration: -29%
↓ importSrpHome/longTaskMaxDuration: -20%
↓ importSrpHome/tbt: -41%
↓ importSrpHome/total: -34%
↓ importSrpHome/inp: -20%
↓ importSrpHome/cls: -50%
↓ sendTransactions/openSendPageFromHome: -41%
↑ sendTransactions/selectTokenToSendFormLoaded: +33%
↑ sendTransactions/longTaskCount: +11%
↑ sendTransactions/longTaskTotalDuration: +18%
↑ sendTransactions/tbt: +35%
↑ sendTransactions/lcp: +31%
↓ sendTransactions/cls: -81%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 importSrpHome/INP: p75 216ms
🟡 sendTransactions/INP: p75 248ms
🟡 importSrpHome/FCP: p75 1.9s
🟡 sendTransactions/FCP: p75 1.9s

Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs [🚀 Bundle size reduced!]

background: 47 Bytes (0%)
ui: 1 KiB (0.01%)
common: -33.58 KiB (-0.25%)

mm-token-exchange-service · 2026-06-15T16:29:47Z

Builds ready [6120af4] [reused from 89595b0]

⚠️ Make sure the build is safe before downloading and running this build.
- Please do not use these builds with accounts that contain significant real money.
- Beware the security risks of cache poisoning.
Webpack builds: chrome, firefox
Webpack builds (beta): chrome, firefox
Webpack builds (flask): chrome, firefox
Webpack builds (test): chrome, firefox
Webpack builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
bundle analyzer: Bundle Analyzer
interaction-benchmark: Interaction Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts

Deprecated Browserify fallback builds

Browserify builds: chrome, firefox
Browserify builds (beta): chrome, firefox
Browserify builds (flask): chrome, firefox
Browserify builds (test): chrome, firefox
Browserify builds (test-flask): chrome, firefox

⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 6 warn · 🔴 0 fail)

Baseline (latest main): 979f290 | Date: 6/15/2026 | Pipeline: 27559111925 | Baseline logs

Interaction Benchmarks · Samples: 5

Benchmark chrome-webpack firefox-webpack
loadNewAccount
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
bridgeUserActions
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
🟡 bridge_search_token

📈 Results compared to the previous 5 runs on main
↓ loadNewAccount/inp: -10%
↓ confirmTx/inp: -12%
↓ confirmTx/lcp: -63%
↑ bridgeUserActions/bridge_load_asset_picker: +23%
↓ bridgeUserActions/inp: -15%
↑ loadNewAccount/load_new_account: +619%
↑ loadNewAccount/total: +619%
↓ loadNewAccount/inp: -10%
↓ loadNewAccount/fcp: -48%
↑ loadNewAccount/lcp: +1053%
↓ confirmTx/longTaskCount: -100%
↓ confirmTx/longTaskTotalDuration: -100%
↓ confirmTx/longTaskMaxDuration: -100%
↓ confirmTx/tbt: -100%
↓ confirmTx/inp: -12%
↓ confirmTx/fcp: -44%
↑ confirmTx/lcp: +347%
↑ bridgeUserActions/bridge_load_page: +94%
↑ bridgeUserActions/bridge_load_asset_picker: +293%
↑ bridgeUserActions/bridge_search_token: +194%
↓ bridgeUserActions/longTaskCount: -100%
↓ bridgeUserActions/longTaskTotalDuration: -100%
↓ bridgeUserActions/longTaskMaxDuration: -100%
↓ bridgeUserActions/tbt: -100%
↑ bridgeUserActions/total: +193%
↓ bridgeUserActions/fcp: -46%
↑ bridgeUserActions/lcp: +1190%

Startup Benchmarks · Samples: 100

Benchmark chrome-webpack firefox-webpack
startupStandardHome
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]

📈 Results compared to the previous 5 runs on main
↑ startupStandardHome/uiStartup: +10%
↑ startupStandardHome/load: +11%
↑ startupStandardHome/domContentLoaded: +11%
↑ startupStandardHome/domInteractive: +11%
↑ startupStandardHome/firstPaint: +17%
↑ startupStandardHome/backgroundConnect: +14%
↑ startupStandardHome/loadScripts: +11%
↑ startupStandardHome/setupStore: +10%
↑ startupStandardHome/longTaskTotalDuration: +11%
↑ startupStandardHome/longTaskMaxDuration: +11%
↑ startupStandardHome/tbt: +13%
↑ startupStandardHome/fcp: +13%
↓ startupStandardHome/lcp: -15%
↑ startupPowerUserHome/domInteractive: +10%
↑ startupPowerUserHome/backgroundConnect: +45%
↑ startupPowerUserHome/setupStore: +11%
↓ startupPowerUserHome/numNetworkReqs: -14%
↑ startupPowerUserHome/inp: +19%
↓ startupPowerUserHome/fcp: -12%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🔴 startupPowerUserHome/INP: p75 528ms
🟡 startupPowerUserHome/INP: p75 224ms
🟡 startupPowerUserHome/LCP: p75 2.7s

User Journey Benchmarks · Samples: 5 · mock API

Benchmark chrome-webpack firefox-webpack
onboardingImportWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
assetDetails
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]
importSrpHome
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
sendTransactions
[Sentry log · main/release] 🟡 [CI log] 🟡 [CI log]
swap
[Sentry log · main/release] 🟢 [CI log] 🟢 [CI log]

📈 Results compared to the previous 5 runs on main
↓ onboardingImportWallet/metricsToWalletReadyScreen: -22%
↓ onboardingImportWallet/doneButtonToHomeScreen: -88%
↓ onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
↓ onboardingImportWallet/longTaskCount: -80%
↓ onboardingImportWallet/longTaskTotalDuration: -94%
↓ onboardingImportWallet/longTaskMaxDuration: -91%
↓ onboardingImportWallet/tbt: -98%
↓ onboardingImportWallet/total: -87%
↓ onboardingNewWallet/doneButtonToAssetList: -16%
↓ onboardingNewWallet/longTaskCount: -55%
↓ onboardingNewWallet/longTaskTotalDuration: -37%
↓ onboardingNewWallet/longTaskMaxDuration: -34%
↓ onboardingNewWallet/tbt: -73%
↓ onboardingNewWallet/total: -14%
↓ solanaAssetDetails/assetClickToPriceChart: -70%
↓ solanaAssetDetails/longTaskCount: -100%
↓ solanaAssetDetails/longTaskTotalDuration: -100%
↓ solanaAssetDetails/longTaskMaxDuration: -100%
↓ solanaAssetDetails/tbt: -100%
↓ solanaAssetDetails/total: -70%
↑ solanaAssetDetails/inp: +18%
↓ solanaAssetDetails/cls: -90%
↓ importSrpHome/loginToHomeScreen: -16%
↑ importSrpHome/openAccountMenuAfterLogin: +101%
↓ importSrpHome/homeAfterImportWithNewWallet: -42%
↓ importSrpHome/longTaskCount: -33%
↓ importSrpHome/longTaskTotalDuration: -29%
↓ importSrpHome/longTaskMaxDuration: -20%
↓ importSrpHome/tbt: -41%
↓ importSrpHome/total: -34%
↓ importSrpHome/inp: -20%
↓ importSrpHome/cls: -50%
↓ sendTransactions/openSendPageFromHome: -41%
↑ sendTransactions/selectTokenToSendFormLoaded: +33%
↑ sendTransactions/longTaskCount: +11%
↑ sendTransactions/longTaskTotalDuration: +18%
↑ sendTransactions/tbt: +35%
↑ sendTransactions/lcp: +31%
↓ sendTransactions/cls: -81%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)
🟡 importSrpHome/INP: p75 216ms
🟡 sendTransactions/INP: p75 248ms
🟡 importSrpHome/FCP: p75 1.9s
🟡 sendTransactions/FCP: p75 1.9s

Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle size diffs [🚀 Bundle size reduced!]

background: 47 Bytes (0%)
ui: 1 KiB (0.01%)
common: -33.58 KiB (-0.25%)

n3ps added 2 commits June 15, 2026 10:59

fix: non evm bridge marked as send

191e875

cleanup

89595b0

n3ps requested a review from a team as a code owner June 15, 2026 15:16

n3ps temporarily deployed to pr-comment June 15, 2026 15:16 — with GitHub Actions Inactive

n3ps changed the title ~~N3ps/fix nonevm bridge type~~ fix: non evm bridge activity type Jun 15, 2026

mm-token-exchange-service Bot added the team-core-extension-ux Core Extension UX team label Jun 15, 2026

github-actions Bot added risk:medium size-M labels Jun 15, 2026

n3ps changed the title ~~fix: non evm bridge activity type~~ fix: non evm bridge activity type cp-13-36.0 Jun 15, 2026

n3ps commented Jun 15, 2026

View reviewed changes

n3ps requested a review from a team June 15, 2026 15:20

n3ps enabled auto-merge June 15, 2026 15:24

n3ps temporarily deployed to pr-comment June 15, 2026 15:47 — with GitHub Actions Inactive

Merge branch 'main' into n3ps/fix-nonevm-bridge-type

6120af4

n3ps temporarily deployed to pr-comment June 15, 2026 16:00 — with GitHub Actions Inactive

github-actions Bot added risk:low and removed risk:medium labels Jun 15, 2026

infiniteflower approved these changes Jun 15, 2026

View reviewed changes

NidhiKJha approved these changes Jun 15, 2026

View reviewed changes

infiniteflower disabled auto-merge June 15, 2026 16:26

infiniteflower enabled auto-merge June 15, 2026 16:26

n3ps temporarily deployed to pr-comment June 15, 2026 16:28 — with GitHub Actions Inactive

infiniteflower added this pull request to the merge queue Jun 15, 2026

n3ps added the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Jun 15, 2026

github-actions Bot removed the retry-ci Tells GitHub Actions to retry failed jobs, label removed automatically before the retry label Jun 15, 2026

Merged via the queue into main with commit 821d404 Jun 15, 2026
197 checks passed

infiniteflower deleted the n3ps/fix-nonevm-bridge-type branch June 15, 2026 18:14

github-actions Bot locked and limited conversation to collaborators Jun 15, 2026

metamaskbot added the release-13.37.0 Issue or pull request that will be included in release 13.37.0 label Jun 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: non evm bridge activity type cp-13-36.0#43557

fix: non evm bridge activity type cp-13-36.0#43557
infiniteflower merged 3 commits into
mainfrom
n3ps/fix-nonevm-bridge-type

n3ps commented Jun 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 15, 2026

Uh oh!

n3ps Jun 15, 2026

Uh oh!

n3ps Jun 15, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 15, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

n3ps commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jun 15, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 15, 2026

✨ Files requiring CODEOWNER review ✨

Uh oh!

n3ps Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

n3ps Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

mm-token-exchange-service Bot commented Jun 15, 2026

Uh oh!

mm-token-exchange-service Bot commented Jun 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

n3ps commented Jun 15, 2026 •

edited

Loading