Skip to content

feat: drive RPC connection banner from NetworkConnectionBannerController (WPC-1014) #31225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cryptodev-2s wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: drive RPC connection banner from NetworkConnectionBannerController (WPC-1014) #31225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d59b80
feat: register NetworkConnectionBannerController in Engine
cryptodev-2s Jun 8, 2026
4ac3c93
refactor: drop in-app banner rule and consume NetworkConnectionBanner…
cryptodev-2s Jun 8, 2026
c4c904c
fix(test): add NetworkConnectionBannerController to initial-backgroun…
cryptodev-2s Jun 8, 2026
94cb461
chore: drop psl, ip-regex, and url-utils now that the controller owns…
cryptodev-2s Jun 8, 2026
d1df6dd
chore: keep narrower cast for state-changed event-name skew
cryptodev-2s Jun 10, 2026
8f62d2b
fix: use 69c25f142 preview
cryptodev-2s Jun 10, 2026
aecbf22
test: add unit test for NetworkConnectionBannerControllerMessenger
cryptodev-2s Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 0 additions & 135 deletions app/actions/networkConnectionBanner/index.test.ts
View file
Open in desktop

This file was deleted.

84 changes: 0 additions & 84 deletions app/actions/networkConnectionBanner/index.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion app/components/UI/NetworkConnectionBanner/NetworkConnectionBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { useTailwind } from '@metamask/design-system-twrnc-preset';
import { useAppTheme } from '../../../util/theme';
import { useNetworkConnectionBanner } from '../../hooks/useNetworkConnectionBanner';
import { strings } from '../../../../locales/i18n';
import { NetworkConnectionBannerState } from '../../../reducers/networkConnectionBanner';
import type { NetworkConnectionBannerState } from './types';
import BannerBase from '../../../component-library/components/Banners/Banner/foundation/BannerBase';
import { Theme } from '../../../util/theme/models';
import Animated, {
Expand Down
26 changes: 26 additions & 0 deletions app/components/UI/NetworkConnectionBanner/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,33 @@
import type { Hex } from '@metamask/utils';

/**
* Network Connection Banner Status
*
* Degraded: The network is taking more than 5 seconds to initialize.
* Unavailable: The network is not available.
*/
export type NetworkConnectionBannerStatus = 'degraded' | 'unavailable';

/**
* Shape consumed by the banner UI. Derived from
* `NetworkConnectionBannerController` state via the selector — the
* `visible: false` case maps to the controller's `'available'` status.
*/
export type NetworkConnectionBannerState =
| {
visible: false;
}
| {
visible: true;
chainId: Hex;
status: NetworkConnectionBannerStatus;
networkName: string;
rpcUrl: string;
isInfuraEndpoint: boolean;
/**
* Network client ID of an available Infura endpoint (for custom networks
* that have one) that can be used to switch to Infura. Undefined if no
* Infura endpoint is available.
*/
infuraNetworkClientId?: string;
};
2 changes: 0 additions & 2 deletions app/components/Views/Wallet/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ import Engine from '../../../core/Engine';
import { useSelector } from 'react-redux';
import { mockedPerpsFeatureFlagsEnabledState } from '../../UI/Perps/mocks/remoteFeatureFlagMocks';
import { initialState as cardInitialState } from '../../../core/redux/slices/card';
import { initialState as networkConnectionBannerInitialState } from '../../../reducers/networkConnectionBanner';
import {
NavigationProp,
ParamListBase,
Expand Down Expand Up @@ -477,7 +476,6 @@ const mockInitialState = {
newPrivacyPolicyToastShownDate: null,
newPrivacyPolicyToastClickedOrClosed: false,
},
networkConnectionBanner: networkConnectionBannerInitialState,
engine: {
backgroundState: {
...backgroundState,
Expand Down
Loading
Loading