Skip to content

fix(predict): normalize moneyline betslip labels and icons#31648

Draft
caieu wants to merge 1 commit into
mainfrom
predict/PRED-964-fix-world-cup-bet-submission-ui-incorrect-avatar-and-duplicate-team-name
Draft

fix(predict): normalize moneyline betslip labels and icons#31648
caieu wants to merge 1 commit into
mainfrom
predict/PRED-964-fix-world-cup-bet-submission-ui-incorrect-avatar-and-duplicate-team-name

Conversation

@caieu

@caieu caieu commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes incorrect bet submission header content for Predict moneyline markets, especially World Cup-style markets where the selected outcome could show duplicated team names or the wrong avatar in preview flows.

It introduces a shared buy-header formatter that normalizes neg-risk moneyline selections back to consistent Yes · <team or Draw> labeling, resolves the correct team logo for the selected side, and reuses that logic across the standard buy preview, the preview sheet, and the buy-with-any-token preview header. The PR also adds focused test coverage for the new formatting behavior and draw handling.

Changelog

CHANGELOG entry: Fixed incorrect Predict bet submission labels and icons for moneyline markets.

Related issues

Fixes: PRED-964

Manual testing steps

Feature: Predict moneyline buy preview headers

  Scenario: User opens a moneyline market buy preview
    Given the user opens a Predict sports market with team-based moneyline outcomes
    When the user selects a team outcome and opens the buy preview
    Then the header shows "Yes" as the selected side label
    And the header keeps the selected team name as the descriptor
    And the header shows the selected team's logo instead of a generic outcome image

  Scenario: User opens the buy preview from the pay-with-any-token flow
    Given the user is in the Predict buy-with-any-token flow for a moneyline market
    When the user reaches the preview header
    Then the header uses the same normalized label and team logo as the standard buy preview

  Scenario: User selects a draw moneyline outcome
    Given the user opens a moneyline market that includes a draw outcome
    When the user previews the draw selection
    Then the header shows "Yes" as the selected side label
    And the descriptor is shown as "Draw"

Screenshots/Recordings

Before

Screen.Recording.2026-06-12.at.11.16.00.mov

After

Screen.Recording.2026-06-12.at.11.15.29.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Use shared buy-header formatting so moneyline selections show team logos and
consistent "Yes · <outcome>" labels instead of duplicated outcome text in
World Cup and similar game markets.
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 12, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the team-predict Predict team label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. size-M team-predict Predict team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant