Skip to content

feat: add suggestions to watchlist on marketlist UI#31650

Merged
aganglada merged 7 commits into
mainfrom
perps/watchlist-marketlist-suggestions
Jun 15, 2026
Merged

feat: add suggestions to watchlist on marketlist UI#31650
aganglada merged 7 commits into
mainfrom
perps/watchlist-marketlist-suggestions

Conversation

@gambinish

@gambinish gambinish commented Jun 12, 2026

Copy link
Copy Markdown
Member

Description

Add suggestions to the watchlist on market list UI. Should match behavior on Perps Home, minus the collapsible "show more" button.

Fixes back navigation from asset details screen so that it navigates correctly to Perps Home, or Market List, contextually.

Fixes search bar functionality on Market List Watchlist

Changelog

CHANGELOG entry: add suggested markets to watchlist on marketlist UI

Related issues

Fixes: n/a

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Screen.Recording.2026-06-12.at.9.31.00.AM.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
UI-only perps market list and watchlist component changes behind the existing watchlist flag, with broad test coverage and no auth or data-layer changes.

Overview
Perps market list watchlist mode now mirrors Perps Home: when the watchlist feature flag is on and the watchlist filter is active, the screen always renders PerpsWatchlistMarkets with saved markets and suggested markets—not only when the watchlist is empty. The list view passes enableShowMore={false}, showHeader={false}, and wires row taps through the existing handleMarketPress so onMarketSelect, navigateToMarketDetails, and route transactionActiveAbTests behave like the main market list.

PerpsWatchlistMarkets gains optional onMarketPress (parent-owned navigation instead of internal navigation.navigate) and enableShowMore (default true; when false, all watchlist rows show with no expand/collapse). Both V1 and V2 honor onMarketPress.

Tests cover the new market-list watchlist flows and the new component props.

Reviewed by Cursor Bugbot for commit 6ffb46b. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 12, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the team-perps Perps team label Jun 12, 2026
@mm-token-exchange-service

mm-token-exchange-service Bot commented Jun 12, 2026

Copy link
Copy Markdown

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Manual testing steps still contain template content (the Gherkin example title or a [...] placeholder). Replace with real steps, or write N/A — <reason>.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@gambinish gambinish removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 12, 2026
@gambinish gambinish marked this pull request as ready for review June 12, 2026 16:44
@gambinish gambinish requested a review from a team as a code owner June 12, 2026 16:44
@github-actions github-actions Bot added the risk:medium AI analysis: medium risk label Jun 12, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c049f1d. Configure here.

Comment thread app/components/UI/Perps/Views/PerpsMarketListView/PerpsMarketListView.tsx Outdated
@github-actions github-actions Bot added risk:low AI analysis: low risk and removed risk:medium AI analysis: medium risk labels Jun 12, 2026
@gambinish gambinish added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jun 12, 2026
@github-actions github-actions Bot added risk:medium AI analysis: medium risk and removed risk:low AI analysis: low risk labels Jun 12, 2026
@github-actions github-actions Bot added size-L and removed size-M labels Jun 12, 2026
@gambinish gambinish enabled auto-merge June 12, 2026 19:08
@gambinish gambinish disabled auto-merge June 12, 2026 19:08

@geositta geositta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes unless we have a product decision not to support search? The navigation override and focused tests look good, but the watchlist marketlist search regression should be fixed before merge IMO.

Comment thread app/components/UI/Perps/Views/PerpsMarketListView/PerpsMarketListView.tsx Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform, SmokeConfirmations
  • Selected Performance tags: @PerformancePreps
  • Risk Level: medium
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR modifies Perps-specific UI components:

  1. PerpsMarketListView.tsx: Changes navigation from perpsNavigation.navigateToMarketDetails() to navigation.dispatch(StackActions.push(...)) to fix a stack navigation bug where pressing back from market details could skip the market list and land on PerpsHome. Also enhances the watchlist filter view with search filtering across watchlist and suggested markets, adds a ScrollView wrapper, and adds a "no results" empty state.

  2. PerpsWatchlistMarkets.tsx: Adds onMarketPress prop for parent-controlled navigation override, and enableShowMore prop to disable the collapsible toggle.

  3. Styles and tests: Supporting style additions and comprehensive unit test coverage for the new functionality.

Tag selection rationale:

  • SmokePerps: Primary tag - directly tests Perps functionality including market list navigation and watchlist behavior
  • SmokeWalletPlatform: Required per SmokePerps description - "Perps is also a section inside the Trending tab (SmokeWalletPlatform); changes to Perps views affect Trending"
  • SmokeConfirmations: Required per SmokePerps description - "Add Funds deposits are on-chain transactions"

The navigation change (push vs navigate) is a behavioral fix that could affect the back-navigation flow in Perps, warranting E2E validation. The watchlist search filtering is new functionality that needs testing.

Performance Test Selection:
The PerpsMarketListView changes affect perps market loading and navigation behavior. The @PerformancePreps tag covers perpetuals trading performance including perps market loading and position management, which could be impacted by the ScrollView wrapper addition and the new watchlist filtering logic in PerpsMarketListView.

View GitHub Actions results

@geositta geositta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes and looks good!

@github-actions

Copy link
Copy Markdown
Contributor

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

All tests passed · 2 tests · 1 device

📱 Devices tested (1)

Android: Google Pixel 8 Pro (v14.0)

✅ Passed Tests (2)
Test Platform Device Duration Team Recording
Perps add funds Android Google Pixel 8 Pro (v14.0) 0.00s @mm-perps-engineering-team 📹 Watch
Perps open position and close it Android Google Pixel 8 Pro (v14.0) 19.14s @mm-perps-engineering-team 📹 Watch

Branch: perps/watchlist-marketlist-suggestions · Build: Normal · Commit: f9e9b7d · View full run

@aganglada aganglada added this pull request to the merge queue Jun 15, 2026
Merged via the queue into main with commit ca846b2 Jun 15, 2026
128 checks passed
@aganglada aganglada deleted the perps/watchlist-marketlist-suggestions branch June 15, 2026 08:33
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.83.0 Issue or pull request that will be included in release 7.83.0 label Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.83.0 Issue or pull request that will be included in release 7.83.0 risk:medium AI analysis: medium risk size-L skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants