Cherry-picking commits from main to release/7.82.0 for PR #31555#31653
Open
runway-github[bot] wants to merge 1 commit into
Open
Cherry-picking commits from main to release/7.82.0 for PR #31555#31653runway-github[bot] wants to merge 1 commit into
runway-github[bot] wants to merge 1 commit into
Conversation
…31555) ## **Description** Fix game clock width on the Predict sport scoreboard to prevent wide scores (e.g., 123) from being cut off. On devices like iPhone 17 Pro, the score container had insufficient width, causing scores with 3+ digits to be clipped. The fix adjusts the score display layout to properly accommodate wider score values. ## **Changelog** CHANGELOG entry: Fixed a bug causing wide sport scores to be cut off on the predict scoreboard. ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/PRED-960 ## **Manual testing steps** ```gherkin Feature: Predict sport scoreboard Scenario: user views a game with a wide score (3+ digits) Given the user is on the Predict scoreboard screen And a live or completed sport game has a score of 100 or higher (e.g., Knicks 123 vs Spurs 118) When user views the scoreboard card Then the full score is displayed without being cut off ``` ## **Screenshots/Recordings** ### **Before** <!-- Scores like 123 were clipped on iPhone 17 Pro --> ### **After** <img width="320" alt="Simulator Screenshot - mm-blue - 2026-06-11 at 12 23 33" src="https://github.com/user-attachments/assets/f06ef67d-abd0-46c6-a49c-438aeb8ae8c9" /> <img width="320" alt="Simulator Screenshot - mm-blue - 2026-06-11 at 12 23 25" src="https://github.com/user-attachments/assets/648109fd-b2d7-4bdf-8df2-e25b4ac4b534" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > UI-only layout change in Predict scoreboard; scheduled non-compact cards no longer reserve invisible score slots. > > **Overview** > Updates **Predict sport scoreboard** score rendering so live and final games can show wide scores (e.g. 100+) without clipping. > > **`showScores`** is now tied to **`isLive || isEnded`** instead of hiding scores only in compact scheduled cards. Scheduled games no longer render score text or the old invisible fixed-width placeholders. > > Fixed Tailwind width classes on score **`Text`** (`w-12` / `w-16` / `opacity-0 w-16`) are removed; scores keep padding only so they can grow with digit count and give the center status area more flexible space. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b78a1ea. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix game clock width on the Predict sport scoreboard to prevent wide
scores (e.g., 123) from being cut off. On devices like iPhone 17 Pro,
the score container had insufficient width, causing scores with 3+
digits to be clipped. The fix adjusts the score display layout to
properly accommodate wider score values.
Changelog
CHANGELOG entry: Fixed a bug causing wide sport scores to be cut off on
the predict scoreboard.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/PRED-960
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
UI-only layout change in Predict scoreboard; scheduled non-compact
cards no longer reserve invisible score slots.
Overview
Updates Predict sport scoreboard score rendering so live and final
games can show wide scores (e.g. 100+) without clipping.
showScoresis now tied toisLive || isEndedinstead ofhiding scores only in compact scheduled cards. Scheduled games no longer
render score text or the old invisible fixed-width placeholders.
Fixed Tailwind width classes on score
Text(w-12/w-16/opacity-0 w-16) are removed; scores keep padding only so they can growwith digit count and give the center status area more flexible space.
Reviewed by Cursor Bugbot for commit
b78a1ea. Bugbot is set up for automated
code reviews on this repo. Configure
here.