Skip to content

chore: Resolve platform files for react compiler compatibility#31669

Open
Cal-L wants to merge 18 commits into
mainfrom
chore/MCWP-646-resolve-files-for-react-compiler
Open

chore: Resolve platform files for react compiler compatibility#31669
Cal-L wants to merge 18 commits into
mainfrom
chore/MCWP-646-resolve-files-for-react-compiler

Conversation

@Cal-L

@Cal-L Cal-L commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

These changes addresses platform files that needed resolutions in order to be compatible with React Compiler. Those files are listed here - https://docs.google.com/spreadsheets/d/1w62YHs70AHE6_FGrnp2MBKqAtIQaC-j59C5je1B6yak/edit?gid=437046532#gid=437046532

Changelog

CHANGELOG entry: null

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MCWP-646

Manual testing steps

N/A - Refer to the video. This does not target a specific feature. It's just a smoke test to ensure app functions

Screenshots/Recordings

Before

Refer to after section

After

react-compiled.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L marked this pull request as ready for review June 12, 2026 23:09
@Cal-L Cal-L requested a review from a team as a code owner June 12, 2026 23:09
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Jun 12, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Jun 12, 2026
@Cal-L Cal-L changed the title Chore/mcwp 646 resolve files for react compiler chore: Resolve platform files for react compiler compatibility Jun 12, 2026
@github-actions github-actions Bot added the risk:high AI analysis: high risk label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: @PerformanceLaunch
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (global-infrastructure-change): Global infrastructure changed: app/components/hooks/useAsyncResult.ts, app/components/hooks/useEndTraceOnMount.ts, app/components/hooks/useFavicon/useFavicon.ts, app/components/hooks/useOTAUpdates.ts, app/components/hooks/usePrevious.ts. Running all tests.

Performance Test Selection:
The App.tsx and NavigationProvider.tsx changes affect the NavInit trace timing and app startup flow. ControllersGate.tsx changes the splash screen animation (useAnimatedValue vs useRef). These could affect measured app launch/startup performance. @PerformanceLaunch covers cold start time, splash screen duration, and time to interactive — all potentially affected by the startup trace and animation changes.

View GitHub Actions results

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

All tests passed · 5 tests · 1 device

📱 Devices tested (1)

Android: Google Pixel 8 Pro (v14.0)

✅ Passed Tests (5)
Test Platform Device Duration Team Recording
Cold Start: Measure ColdStart To Login Screen Android Google Pixel 8 Pro (v14.0) 3.38s @metamask-mobile-platform 📹 Watch
Measure Warm Start: Warm Start to Login Screen Android Google Pixel 8 Pro (v14.0) 0.89s @metamask-mobile-platform 📹 Watch
Measure Warm Start: Login To Wallet Screen Android Google Pixel 8 Pro (v14.0) 1.75s @metamask-mobile-platform 📹 Watch
Measure Cold Start To Onboarding Screen Android Google Pixel 8 Pro (v14.0) 3.46s @metamask-mobile-platform 📹 Watch
Cold Start after importing a wallet Android Google Pixel 8 Pro (v14.0) 0.52s @metamask-mobile-platform 📹 Watch

Branch: chore/MCWP-646-resolve-files-for-react-compiler · Build: Normal · Commit: a90acae · View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed risk:high AI analysis: high risk size-L team-mobile-platform Mobile Platform team

Projects

Status: Review finalised - Ready to be merged

Development

Successfully merging this pull request may close these issues.

2 participants