Skip to content

test: migrate SmokeAccounts smoke e2e from Detox to Appium#31680

Open
cmd-ob wants to merge 5 commits into
mainfrom
e2e/appium-smoke-accounts
Open

test: migrate SmokeAccounts smoke e2e from Detox to Appium#31680
cmd-ob wants to merge 5 commits into
mainfrom
e2e/appium-smoke-accounts

Conversation

@cmd-ob

@cmd-ob cmd-ob commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Description

Migrates all currently running main-branch SmokeAccounts smoke flows from Detox to Appium (MMQA-1938).

Test migration

  • Adds Appium specs for multi-SRP SRP export from account actions and settings (tests/smoke-appium/accounts/).
  • Removes the corresponding Detox specs under tests/smoke/accounts/ and tests/smoke/multisrp/ (wallet details, reveal SRP from settings, add account, export SRP flows).
  • The remaining SmokeAccounts Appium coverage (create wallet account, wallet details, reveal SRP) was landed earlier on main; this PR completes the tag migration by deleting the Detox duplicates and wiring CI.

CI / sharding

  • Adds appium-smoke-tests-android to the check-all-jobs-pass gate so Appium smoke is required alongside Detox smoke on PRs.
  • Runs SmokeAccounts on Appium with a 2-shard matrix on iOS and Android.
  • Removes Detox accounts-*-smoke jobs now that no Detox SmokeAccounts specs remain.
  • Rebalances SmokeWalletPlatform Detox shards from 3 → 2 on iOS and Android.

Stability fixes

  • Updates goToAccountActions to use the V2 account ellipsis control and asserts QR on Android Appium during SRP quiz completion.
  • Fixes an iOS Appium flake by using wallet-screen (WALLET_CONTAINER) for WalletView.container instead of the balance-only balance-container locator, which is absent under default zero-balance mocks.

Changelog

CHANGELOG entry: null

Related issues

Refs: MMQA-1938

Manual testing steps

N/A — test and CI infrastructure changes only. Validation is via the Appium SmokeAccounts CI jobs and local Appium smoke runs.

Screenshots/Recordings

Before

N/A — no user-facing UI changes.

After

N/A — no user-facing UI changes.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

@cmd-ob cmd-ob requested review from a team as code owners June 15, 2026 06:35
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added size-L risk:low AI analysis: low risk labels Jun 15, 2026
@cmd-ob cmd-ob added the skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run label Jun 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found

All E2E tests pre-selected.

View GitHub Actions results

@cmd-ob cmd-ob enabled auto-merge June 15, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low AI analysis: low risk size-L skip-smart-e2e-selection Skip Smart E2E selection, i.e. select all E2E tests to run team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants