Investigation: Viem Breaking Change in WebAuthn Types (Issue #188)#190
Closed
jeffsmale90 wants to merge 1 commit intomainfrom
Closed
Investigation: Viem Breaking Change in WebAuthn Types (Issue #188)#190jeffsmale90 wants to merge 1 commit intomainfrom
jeffsmale90 wants to merge 1 commit intomainfrom
Conversation
Investigated the breaking change in viem that affects #188. Key findings: - Breaking change introduced in ox@0.6.5 on Nov 24, 2025 - Commit d11e1fb made challengeIndex, typeIndex, and userVerificationRequired optional - This change propagated to viem through its ox dependency update - Affects smart-accounts-kit's WebAuthn type expectations The specific PR that introduced the breaking change: wevm/ox@d11e1fb Co-authored-by: jeffsmale90 <jeffsmale90@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR documents the investigation into the breaking change in viem that causes TypeScript errors in smart-accounts-kit as described in #188.
Root Cause
The breaking change was introduced in ox@0.6.5 on November 24, 2025 via commit d11e1fbd.
The Breaking Change
The commit titled "feat: modify
WebAuthnP256.verifyto work with minimal metadata" made the following fields inSignMetadataoptional:challengeIndex?: number | undefined(was:challengeIndex: number)typeIndex?: number | undefined(was:typeIndex: number)userVerificationRequired?: boolean | undefined(was:userVerificationRequired: boolean)This change propagated to viem when it updated its
oxdependency, causing type incompatibilities in smart-accounts-kit.Timeline
Specific PR That Introduced the Breaking Change
Repository: wevm/ox
Commit: d11e1fbd2554194a67d37c4da34dcf9f749e3698
Date: November 24, 2025
Author: @jxom
Documentation
See INVESTIGATION_RESULTS.md for complete details including:
Related
Fixes #188
Slack Thread