feat(STX-501): add remote feature flag routing to getAPIRequestURL for sentinel migration#580
Merged
rarquevaux merged 1 commit intomainfrom Apr 16, 2026
Conversation
ac311a1 to
66fb7cf
Compare
66fb7cf to
0c8d6bd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0c8d6bd. Configure here.
Gate each sentinel API endpoint behind a dedicated remote feature flag.
0c8d6bd to
43e8d91
Compare
nthpool
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
getAPIRequestURL()via an optionaluseSentinelparameterBATCH_STATUS,GET_FEES,SUBMIT_TRANSACTIONS,CANCEL) behind a dedicated LaunchDarkly flagfalse— no production traffic shifts on merge; each endpoint can be switched independentlyTest plan
yarn test— all tests passyarn lint:fix— 0 errorsNote
Medium Risk
Touches Smart Transactions fee/status/submit/cancel API routing; while gated by remote flags defaulting off, misconfigured flags could shift traffic to new Sentinel endpoints and affect transaction flows.
Overview
Adds remote-feature-flag controlled routing to send Smart Transactions
GET_FEES,SUBMIT_TRANSACTIONS,CANCEL, andBATCH_STATUSrequests to Sentinel/v1/...endpoints on supported chains.SmartTransactionsControllernow reads per-endpoint migration flags (e.g.,stxMigrationGetFees) and passes a newuseSentineloption intogetAPIRequestURL, which falls back to the legacyAPI_BASE_URLwhen disabled or unsupported. Unit tests expand coverage for the newuseSentinelrouting and fallback behavior.Reviewed by Cursor Bugbot for commit 43e8d91. Bugbot is set up for automated code reviews on this repo. Configure here.