Skip to content

⚡ Bolt: [performance improvement] optimize array filtering #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yeboster wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Bolt: [performance improvement] optimize array filtering #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/routes/api/proposals/voters/add/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ export async function GET() {
?.setValue()
.values.map((voter) => voter.addressValue().value.toString('hex')) ?? [];

const newVoters = owners.filter((owner) => !voters.includes(owner)).slice(0, 50);
// Optimize O(N*M) lookup to O(N) using a Set
const votersSet = new Set(voters);
const newVoters = owners.filter((owner) => !votersSet.has(owner)).slice(0, 50);
if (newVoters.length === 0) return json({ newVoters }, { status: 200 });

const votingContract = await metaNamesSdk.contractRepository.getContract({
Expand Down
4 changes: 3 additions & 1 deletion src/routes/api/proposals/voters/remove/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export async function GET() {
?.setValue()
.values.map((voter) => voter.addressValue().value.toString('hex')) ?? [];

const votersToRemove = voters.filter((voter) => !owners.includes(voter)).slice(0, 50);
// Optimize O(N*M) lookup to O(N) using a Set
const ownersSet = new Set(owners);
const votersToRemove = voters.filter((voter) => !ownersSet.has(voter)).slice(0, 50);
if (votersToRemove.length === 0) return json({ newVoters: votersToRemove }, { status: 200 });

const votingContract = await metaNamesSdk.contractRepository.getContract({
Expand Down