🎨 Palette: [UX improvement] Fix duplicate IDs in Dialog of Record component#192
🎨 Palette: [UX improvement] Fix duplicate IDs in Dialog of Record component#192
Conversation
Co-authored-by: yeboster <23556525+yeboster@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
💡 What: Generated unique IDs for
TitleandContentsections of the SMUIDialoginRecord.svelte, linking them properly witharia-labelledbyandaria-describedbyusing a generateddialogId.🎯 Why: When multiple
Recordcomponents are rendered together, they each instantiated aDialogwith identical static IDs (simple-title,simple-content). This breaks HTML uniqueness constraints and causes accessibility issues where screen readers could reference the wrong elements for labeling and description.♿ Accessibility: Prevents duplicate ID conflicts and ensures correct referencing by screen readers via
aria-labelledbyandaria-describedbyattributes.PR created automatically by Jules for task 10372727076720569112 started by @yeboster