Skip to content

🎨 Palette: [UX improvement] - Improve Profile Search Input UX and Ledger Wallet a11y #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
yeboster wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🎨 Palette: [UX improvement] - Improve Profile Search Input UX and Ledger Wallet a11y #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/WalletConnectButton.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@
<Item on:SMUI:action={connectWithLedgerWallet}>
<Text>
<div class="item">
<img class="logo" src={ledgerWalletLogo} alt="partisia wallet logo" />
<img class="logo" src={ledgerWalletLogo} alt="ledger wallet logo" />
<span>Ledger</span>
</div>
</Text>
Expand Down
14 changes: 10 additions & 4 deletions src/routes/profile/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

if (trimmedDomain.startsWith(trimmedSearch) || trimmedDomain.includes(trimmedSearch))
return true;
else false;
else return false;
}
</script>

Expand All @@ -59,9 +59,15 @@
>
<svelte:fragment slot="trailingIcon">
<div class="close-icon">
<IconButton on:click={cleanSearch} aria-label="cancel">
<Icon icon="cancel" />
</IconButton>
{#if search.length > 0}
<IconButton on:click={cleanSearch} aria-label="clear search">
<Icon icon="cancel" />
</IconButton>
{:else}
<IconButton aria-label="search" disabled>
<Icon icon="search" />
</IconButton>
{/if}
</div>
</svelte:fragment>
</Textfield>
Expand Down