🎨 Palette: [UX improvement] Fix duplicated a11y IDs in Record Dialog#206
🎨 Palette: [UX improvement] Fix duplicated a11y IDs in Record Dialog#206
Conversation
Fixes accessibility issues where the Dialog for confirming record deletion had hardcoded IDs ("simple-title", "simple-content"). When multiple `Record` components are rendered (e.g., in a loop inside `Records.svelte`), this caused duplicate ID violations and mismatched `aria-labelledby` / `aria-describedby` associations for screen readers.
By generating a unique ID per component instance via `onMount`, we ensure each Dialog remains accessible and correctly associates its title and content without causing SSR hydration mismatches.
Co-authored-by: yeboster <23556525+yeboster@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
💡 What: Dynamically generated unique IDs for the confirmation dialog in
Record.svelte.🎯 Why: Because
Recordcomponents can be rendered in a list, hardcoded IDs for the dialog's title and content were causing duplicate ID accessibility errors and breaking screen reader associations.📸 Before/After: Visuals remain identical; improvements are strictly related to correct ARIA associations.
♿ Accessibility: Resolves duplicate ID violations and ensures screen readers correctly announce the dialog title and content.
PR created automatically by Jules for task 3055824789617018908 started by @yeboster