🎨 Palette: dynamic search/cancel icon in Profile#209
Conversation
Replaced the persistent cancel icon with a disabled search icon when the search input is empty, and an active cancel icon when text is entered, providing clear visual feedback and functionality. Also fixed a small TS error in `isFuzzyMatch`. Co-authored-by: yeboster <23556525+yeboster@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
Replaced the persistent cancel icon with a disabled search icon when the search input is empty, and an active cancel icon when text is entered in the profile domain search input. Also fixed a TS error in
isFuzzyMatchmissing a return statement.🎯 Why:
Users could be confused by a 'cancel' icon when there was nothing to cancel or clear. A search icon better represents the default state, while the clear icon correctly replaces it when there is text to clear.
📸 Before/After:
♿ Accessibility:
Added accurate ARIA labels for both states (
aria-label="search"andaria-label="clear search"). Disabled the button in the empty state to prevent screen readers and keyboard users from interacting with a null action.PR created automatically by Jules for task 1452290513781893684 started by @yeboster