refactor(render/sarif): split into submodule directory (#57 3/3)#65
Merged
Conversation
src/render/sarif.rs (1205 LOC) -> src/render/sarif/: - mod.rs (73): docstring, consts, module decls, pub use render - document.rs (32): pub fn render orchestrator - rules.rs (128): fn rules + fn rule - results.rs (350): fn results (twelve-loop finding emitter) - helpers.rs (58): fingerprint, plugin_sarif_level, synthetic_location, sarif_level - tests.rs (588): #[cfg(test)] mod tests Biggest non-test file: results.rs at 350 LOC. Pure cut-paste, zero behavior change. Public API path crate::render::sarif::render preserved. 429 lib tests pass, clippy clean. Closes #57 (all three splits landed: run.rs #62, maintainer.rs #64, sarif.rs).
Coverage reportLine coverage: 83.6% (9129 / 10921 lines) Full lcov report available as workflow artifact coverage-lcov: download from this run. v0.9.8 introduces this report; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final part of #57 (module size budget round 2). Follows #62 (run.rs) and #64 (maintainer.rs).
What
src/render/sarif.rs(1205 LOC) split intosrc/render/sarif/:pub use document::renderpub fn renderorchestratorfn rules+fn rulefn results(the twelve-loop finding emitter)fingerprint,plugin_sarif_level,synthetic_location,sarif_level#[cfg(test)] mod testsBiggest non-test file: results.rs at 350 LOC.
Behavior change
None. Pure mechanical cut-paste. Public path
crate::render::sarif::renderpreserved (verified via src/run.rs:403).fingerprinthad beenpub(crate)but has zero out-of-module callers — narrowed to module-private (tests reach it via#[cfg(test)]re-export in mod.rs).Verification
Closes #57
After this merges, all three splits (run.rs, maintainer.rs, sarif.rs) are in. Crate's biggest non-test file drops from 1284 LOC to <600.