Set start and end keys to null in dataloader matadata#120
Open
Set start and end keys to null in dataloader matadata#120
start and end keys to null in dataloader matadata#120Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small configuration change by explicitly setting the
startandendparameters tonullin theresources/inference/metadata/sgm-multidataset-ich1-oper-patch.yamlfile. This addresses the recurrent issue of wrong test time range in the checkpoints that result in errors when we try to run evaluation for dates outside of said period.I would define this a "dirty fix", but I believe this is a pragmatic way to solve this that should not result in any problem.