Support baselines in runs and make baseline_id optional#121
Open
Support baselines in runs and make baseline_id optional#121
runs and make baseline_id optional#121Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
runslist (alongside forecasters and interpolators) and simplify baseline configuration by makingbaseline_idoptional.baselinesblock while encouraging the new inline format.Description
BaselineConfig.baseline_idis optional (str | None) and its description documents that it defaults to thelabelwhen omitted.ConfigModel.runsto acceptBaselineItementries and mark the top-levelbaselineslist as deprecated with a default empty list.workflow/tools/config.schema.json) to reflect the nullablebaseline_id, allowBaselineIteminruns, and remove the requirement for the legacy top-levelbaselinesfield.workflow/rules/common.smkso baseline entries inconfig['runs']are ignored bycollect_all_runs, collected bycollect_all_baselines(usingbaseline_idfallback tolabel), and legacy top-level baselines remain supported.baselinesblock where applicable and add/maintain inline baseline entries.test_legacy_top_level_baselines_still_supportedandtest_workflow_parsing_excludes_baselines_from_run_configs.Testing
pytest tests/unit/test_config.py) focusing on config validation and workflow parsing, and all tests passed.test_legacy_top_level_baselines_still_supportedandtest_workflow_parsing_excludes_baselines_from_run_configssucceed.Codex Task