Skip to content

Adapt probtest workflow to LETKF outputs#83

Merged
cghielmini merged 45 commits intomainfrom
adapt_to_ekf
Mar 6, 2026
Merged

Adapt probtest workflow to LETKF outputs#83
cghielmini merged 45 commits intomainfrom
adapt_to_ekf

Conversation

@cghielmini
Copy link
Collaborator

This merge request aims to adapt the protest workflow to LETKF outputs.

Copy link

@clairemerker clairemerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR! :)
I have a broader question regarding the logic we are trying to implement for fof_compare, please have a look at https://github.com/MeteoSwiss/probtest/pull/83/changes#r2676392953 before looking at my other comments. Maybe we can discuss, I am not sure I am remembering what we decided correctly, and I might be confused here...

Copy link
Collaborator

@huppd huppd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these improvements and alignment with the other workflow. I just reviewed roughly the technical aspects and only have a few suggestions.

cghielmini and others added 2 commits March 3, 2026 08:34
Co-authored-by: Daniel Hupp <daniel.hupp@meteoswiss.ch>
@cghielmini
Copy link
Collaborator Author

Thanks for your review:)

@cghielmini
Copy link
Collaborator Author

Thanks for your comment. It was a test related to the old version of probtest. We don't need it anymore, so I deleted it.

Copy link

@clairemerker clairemerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @huppd for the comments and @cghielmini for the improvements :)

@cghielmini cghielmini merged commit 6ce3934 into main Mar 6, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants