[WIP] Add scan manifests button to dashboard footer#64
Merged
sketch0395 merged 2 commits intomainfrom Mar 19, 2026
Merged
Conversation
Co-authored-by: sketch0395 <33059841+sketch0395@users.noreply.github.com>
Copilot stopped work on behalf of
sketch0395 due to an error
March 19, 2026 04:05
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “Scan Manifest” affordance to the generated security dashboard so users can view scan manifest metadata and file hashes directly from the UI.
Changes:
- Loads
scan-manifest.jsonduring dashboard generation and embeds it into the HTML as a JS variable. - Adds footer button + modal (HTML/CSS/JS) to display manifest details and file hashes.
- Extends Bats tests to assert the new manifest-related elements/functions are present in the generator script.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
scripts/shell/generate-security-dashboard.sh |
Loads/escapes scan manifest JSON, adds footer button + modal UI, and implements open/close/render JS. |
tests/shell/test-generate-security-dashboard.bats |
Adds grep-based checks ensuring the manifest load/button/modal/JS hooks exist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "⚠️ Failed to parse scan manifest JSON" | ||
| else | ||
| # Escape for safe HTML embedding: replace </ with <\/ to prevent script tag injection | ||
| SCAN_MANIFEST_JSON=$(echo "$SCAN_MANIFEST_JSON" | sed 's|</|<\\/|g') |
Comment on lines
+4609
to
+4612
| <div class="manifest-modal" id="scanManifestModal"> | ||
| <div class="manifest-modal-header"> | ||
| <h2 class="manifest-modal-title">🔏 Scan Manifest</h2> | ||
| <button class="manifest-modal-close" onclick="closeScanManifestModal()" title="Close">✕</button> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate-security-dashboard.shtest-generate-security-dashboard.batsto verify the new button and modalOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.