Fixed Like logic in SongMenu.#3089
Closed
fricht wants to merge 2 commits intoMetrolistGroup:mainfrom
Closed
Conversation
added 2 commits
March 1, 2026 14:36
Member
|
can you verify that your change works, and doesnt cause issues when "auto download on like" is turned off? you can download the CI build for your changes here |
Author
|
Ok now i discovered some more inconsistencies / bugs when liking songs : the song tile in the playlist view does not updte properly. |
Member
|
stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Songs are not auto downloading when liked from some SongMenu (with auto download on).
Cause
Inconsistent like logic across menus.
Solution
Changed it to use the dedicated function.
Testing
This change has not been tested.
I can't compile the app, i would appreciate anyone testing this change.
Related Issues