Feature/vasundharam exchange rate provider#794
Open
Vasundhara369 wants to merge 2 commits intoMewsSystems:masterfrom
Open
Feature/vasundharam exchange rate provider#794Vasundhara369 wants to merge 2 commits intoMewsSystems:masterfrom
Vasundhara369 wants to merge 2 commits intoMewsSystems:masterfrom
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exchange Rate Updater
Application that fetches exchange rates from Czech National Bank (CNB) for specified currencies.
Separation of Concerns
The codebase follows a clear layered architecture:
Currency,ExchangeRate) - Domain entities with validationExchangeRateProvider- Main service that coordinates exchange rate retrievalCnbExchangeRateService- HTTP client for CNB API communicationCnbResponseParser- XML parsing logicKey Design Principles Used
Single Responsibility Principle: Each class has one clear purpose:
CnbExchangeRateService- HTTP communication onlyCnbResponseParser- XML parsing onlyExchangeRateProvider- Business logic onlyDependency Injection: All dependencies injected via constructors
Interface-based Design: Interfaces (
ICnbExchangeRateService,ICnbResponseParser) allow for swapping without changing business logic.Reliability & Resilience
CnbApiExceptionFuture Improvements
Notes
cs-CZ) for parsing decimal values (uses comma as decimal separator)