Change dataManager to string data using async reads#1
Open
IceRaptor wants to merge 6 commits intoMhburg:masterfrom
Open
Change dataManager to string data using async reads#1IceRaptor wants to merge 6 commits intoMhburg:masterfrom
IceRaptor wants to merge 6 commits intoMhburg:masterfrom
Conversation
…quest (but still use AmmunitionDef as target)
Owner
|
the pathing is alright, I am just gonna go ahead and remove the csproj files, then readd the new code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default DataManager.StringDataLoadRequest() makes a blocking call to fetch a file. This changes the logic to use an async read, which is then handed by a synchronous handler. This improves loading time somewhat, sharply dropping File I/O time as the DM does an alright job of handling multiple loads.
Sorry for the project paths getting changed, I thought I had excluded those. I can switch to a Directory.Build.props model like I did for ModTek, that wouldn't cause these to be overwritten.