don't try to reach STS if role_arn is not specified#1
Open
MichaelCosby wants to merge 2 commits intomasterfrom
Open
don't try to reach STS if role_arn is not specified#1MichaelCosby wants to merge 2 commits intomasterfrom
MichaelCosby wants to merge 2 commits intomasterfrom
Conversation
We should only try to reach AWS Simple Token Service is the role_arn was specified. This solves the situation where telegraf is running inside a VPC and doesn't have access to STS but is instead using IAM credentials or another auth mechanism, but auth fails because STS is unreachable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When telegraf is running inside a VPC, STS may not be reachable. This makes the cloudwatch output plugin fail before it even tries other methods of getting its authentication tokens.
Since the documentation already states that STS is only tried if role_arn is specified, this patch skips STS entirely if the role_arn is blank.
Required for all PRs:
Since the change I'm making here simply makes the existing README.md true, there was no need to modify it.
I didn't add a unit test; I don't know enough about go yet to know how to mock out the sts module and the existing tests don't have a good example top copy. Assuming that's required for this change, I can learn that...