Chart.js bundle update and hover fix#10
Open
ghost wants to merge 2 commits intoMichaelVoelkel:masterfrom
Open
Conversation
added 2 commits
October 6, 2021 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR introduces two changes:
AD 1) As for the Chart.js update my M.O. was to:
All changes that were available between original bundles were added, all other were kept as-is (customizations for the QML). Seems to be fine but it would be nice if verified by someone more proficient in JS. :)
AD 2) I suppose the fixed values were used for testing and never uncommented. I haven't seen any side effects of uncommenting those other than fixed behavior of changing point style during hover event.
Attached GIFs presenting behavior for such a point style:
BEFORE THE CHANGES
AFTER THE CHANGES