Fix python example issues on Gen4 device#291
Open
xyan264 wants to merge 1 commit intoMicrosemi:develfrom
Open
Conversation
Gen4 device does not need sending MRPC_DIETEMP_SET_MEAS command before reading device temperature. Device generation information is determined using MRPC_PING command
lsgunth
approved these changes
Oct 20, 2021
Collaborator
lsgunth
left a comment
lsgunth
left a comment
There was a problem hiding this comment.
Starts to get a bit more complicated than we'd like for an example. There are other examples that probably need to be fixed as well that are going to be harder. Might be better to change to a different MRPC command for the example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gen4 device does not need sending MRPC_DIETEMP_SET_MEAS command before reading device temperature, so the python example gets an error when running on Gen4 device.
We determine device Gen using MRPC_PING command, and skip MRPC_DIETEMP_SET_MEAS for Gen3 device.