Fixing logic issue with Gen5 Diag Eye diagram on CLI#362
Open
mspicer wants to merge 2 commits intoMicrosemi:masterfrom
Open
Fixing logic issue with Gen5 Diag Eye diagram on CLI#362mspicer wants to merge 2 commits intoMicrosemi:masterfrom
mspicer wants to merge 2 commits intoMicrosemi:masterfrom
Conversation
…ot if the switch was not a Gen5 switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found that the logic to make sure the device being used is Gen5 was checking if the dev pointer existed and then would fail on Gen5 devices saying an error about not for Gen4.
if (dev) {
...
}
Changed to follow the other checking for Gen5 device.
Tested both Gen4 and Gen5 eye diagrams to validate the commit correctly fixes the issue.