Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Persistent Buffer for TCP Stream Reading
Refactors the TCP reading logic to use a persistent BytesMut buffer instead of creating new allocations for every incoming packet. This change resolves potential framing bugs where messages are split across packets and significantly reduces memory allocation overhead.
The Problem
Previously, the reading logic had two critical issues:
Memory Churn: We were allocating a new buffer for every single read operation.
Framing Bugs: If a TCP packet contained a partial message (e.g., the last 3 bytes of a header), or multiple messages back-to-back, the previous logic risked discarding the "overflow" bytes or failing to stitch the message together correctly.
Solution
I have introduced a persistent BytesMut buffer stored in the connection struct.