CI: always-on gitleaks secret scanning#439
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
New .github/workflows/secret-scan.yml runs on every push to a tracked branch and every pull request (NOT marker-gated, unlike deploy.yml): a committed credential should never depend on remembering a marker. It downloads a pinned, checksum-verified gitleaks 8.21.2 and scans the working tree. .gitleaks.toml extends the default high-signal ruleset (OpenAI sk- keys, GitHub/AWS tokens, private keys, mnemonics) and allowlists this repo's structural false positives, each verified against a full tree + history scan: public EVM addresses (40-hex, so a 64-hex private key still fires), the standard demo JWT used as the decode-jwt example, and the leak-guard test's own canary fixtures. With the config the current tree scans clean. Verified locally: without the config gitleaks flags 17 tree hits, all public addresses / demo JWTs / fake fixtures; with the config the tree is clean and the pinned linux asset + checksum grep both resolve. Real secrets live only in Railway env and GitHub Actions secrets, never in the repo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
MikeyPetrillo
marked this pull request as ready for review
July 18, 2026 03:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds committed-secret scanning that runs on every push and PR, independent of the deploy marker system.
What
.github/workflows/secret-scan.yml: always-on (not marker-gated). Downloads a pinned, checksum-verified gitleaks 8.21.2 and scans the working tree on every push to a tracked branch and every pull request..gitleaks.toml: extends the default high-signal ruleset (OpenAI sk- keys, GitHub/AWS tokens, private keys, mnemonics) and allowlists this repo's structural false positives.Allowlist is precise, not blanket
Each entry was verified against a full tree + history scan. The pre-existing hits are all non-secrets: public EVM contract/wallet addresses (allowlisted as 40-hex, so a real 64-hex private key still fires), the standard demo JWT used as the decode-jwt worked example, and the leak-guard test's own canary fixtures. Test-file and docs paths are allowlisted since they carry fake creds by design.
Verified
Without the config: 17 tree findings, all confirmed public addresses / demo JWTs / fake fixtures. With the config: tree scans clean, and the pinned linux asset name + checksum grep both resolve (HTTP 200, sha256 match). One history-only hit (a UUID in a since-removed, now-gitignored
.remember/notes file) does not affect the tree scan.Real secrets live only in Railway env and GitHub Actions secrets, never in the repo — this workflow keeps it that way.
🤖 Generated with Claude Code