Feature: Added static site generation for GitHub Pages (Funcionalidad: Generación de sitio estático para GitHub Pages)#17
Merged
Miles-Arts merged 1 commit intomainfrom May 1, 2025
Conversation
…: Generación de sitio estático para GitHub Pages)
Reviewer's GuideImplemented static site generation for GitHub Pages using a Node.js script with the EJS templating engine, outputting files to the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @Miles-Arts - I've reviewed your changes - here's some feedback:
- The committed
docs/index.htmlappears to contain hardcoded content that thegenerate_static.jsscript is also designed to generate. - The source template (
views/index.ejs) and static assets (public/*) referenced bygenerate_static.jsseem to be missing from this PR.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| max-width: 130%; /* Mantiene el tamaño actual de las imágenes al 130% del ancho del contenedor */ | ||
| height: auto; /* Mantiene la proporción de las imágenes */ | ||
| margin: center; /* Centra las imágenes horizontalmente */ |
There was a problem hiding this comment.
issue (bug_risk): Invalid CSS value for margin in .mona-images.
Use margin: 0 auto; or set margin-left and margin-right to auto to center the images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made\n- Added a script to generate static files for GitHub Pages.\n- Created a folder to host the static site.\n- Updated the project to support deployment on GitHub Pages.\n\n### Cambios Realizados\n- Se añadió un script para generar archivos estáticos para GitHub Pages.\n- Se creó una carpeta para alojar el sitio estático.\n- Se actualizó el proyecto para soportar despliegue en GitHub Pages.
Summary by Sourcery
Add static site generation for GitHub Pages deployment, creating a simple web page with haikus and an Octocat image
New Features:
Deployment:
Documentation:
Chores: