Skip to content

Feature: Added static site generation for GitHub Pages (Funcionalidad: Generación de sitio estático para GitHub Pages)#17

Merged
Miles-Arts merged 1 commit intomainfrom
milton_figueredo
May 1, 2025
Merged

Feature: Added static site generation for GitHub Pages (Funcionalidad: Generación de sitio estático para GitHub Pages)#17
Miles-Arts merged 1 commit intomainfrom
milton_figueredo

Conversation

@Miles-Arts
Copy link
Copy Markdown
Owner

@Miles-Arts Miles-Arts commented May 1, 2025

Changes Made\n- Added a script to generate static files for GitHub Pages.\n- Created a folder to host the static site.\n- Updated the project to support deployment on GitHub Pages.\n\n### Cambios Realizados\n- Se añadió un script para generar archivos estáticos para GitHub Pages.\n- Se creó una carpeta para alojar el sitio estático.\n- Se actualizó el proyecto para soportar despliegue en GitHub Pages.

Summary by Sourcery

Add static site generation for GitHub Pages deployment, creating a simple web page with haikus and an Octocat image

New Features:

  • Created a static site generation script using Node.js and EJS
  • Developed a responsive HTML page with haikus and GitHub Octocat imagery

Deployment:

  • Configured static site generation for GitHub Pages
  • Added script to generate static files in the 'docs' directory

Documentation:

  • Created index.html with responsive design
  • Added CSS styling for the static site

Chores:

  • Implemented a page reload mechanism with a countdown timer

…: Generación de sitio estático para GitHub Pages)
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 1, 2025

Reviewer's Guide

Implemented static site generation for GitHub Pages using a Node.js script with the EJS templating engine, outputting files to the docs directory.

File-Level Changes

Change Details Files
Added a Node.js script to generate static HTML.
  • Utilized ejs library to render an HTML template (views/index.ejs) with predefined data.
  • Created the docs directory if it doesn't exist.
  • Wrote the generated HTML content to docs/index.html.
  • Copied static assets from a public directory to the docs directory using fs.cp.
generate_static.js
Added generated static site files for GitHub Pages.
  • Included the main HTML file (docs/index.html) generated by the script.
  • Added CSS (docs/css/main.css) for styling, including layout, typography, image effects, and responsive design.
  • Embedded a JavaScript countdown timer in the HTML to auto-refresh the page.
docs/index.html
docs/css/main.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Miles-Arts Miles-Arts merged commit c5ceec4 into main May 1, 2025
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Miles-Arts - I've reviewed your changes - here's some feedback:

  • The committed docs/index.html appears to contain hardcoded content that the generate_static.js script is also designed to generate.
  • The source template (views/index.ejs) and static assets (public/*) referenced by generate_static.js seem to be missing from this PR.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread docs/css/main.css

max-width: 130%; /* Mantiene el tamaño actual de las imágenes al 130% del ancho del contenedor */
height: auto; /* Mantiene la proporción de las imágenes */
margin: center; /* Centra las imágenes horizontalmente */
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Invalid CSS value for margin in .mona-images.

Use margin: 0 auto; or set margin-left and margin-right to auto to center the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant