Update to dartastic_opentelemetry 1.1.0-beta.6 / api 1.0.0-beta.7, fix #15 - #19
Open
benjaben wants to merge 1 commit into
Open
Update to dartastic_opentelemetry 1.1.0-beta.6 / api 1.0.0-beta.7, fix #15#19benjaben wants to merge 1 commit into
benjaben wants to merge 1 commit into
Conversation
Fixes compilation against the dartastic beta releases, resolving the breaking API changes introduced since the alpha versions: - Rename Logger → OTelLogger throughout (ui_logger, ui_logger_create, barrel export) - Add timeProvider getter/setter to UITracerProvider and UITracer - Remove @OverRide from recordSpan/recordSpanAsync/startSpanWithContext (removed from Tracer interface); implement locally via startSpan - Replace SessionViewSemantics → RumSessionView (ui_semantics rename) - Remove ~25 Resource/Semantics types from barrel export that no longer exist in the API package (DatabaseResource, DeploymentResource, etc.) - Remove redundant dartastic_opentelemetry_api imports now subsumed by the SDK import All 30 tests pass, including the MaterialApp (non-GoRouter) navigation tests that confirm the invalid-cast fix from issue MindfulSoftwareLLC#15 is working. Closes MindfulSoftwareLLC#15
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dartastic_opentelemetryconstraint to^1.1.0-beta.6anddartastic_opentelemetry_apito^1.0.0-beta.7OTelNavigatorObserver) via the existingMaterialApp (non-GoRouter)test group — all 30 tests passBreaking API changes addressed
Loggerrenamed toOTelLoggerui_logger.dart,ui_logger_create.dart, barrel exportTracerProvider/TracergainedtimeProviderfieldui_tracer_provider.dart,ui_tracer.dartrecordSpan,recordSpanAsync,startSpanWithContextremoved fromTracerinterfaceui_tracer.dart(implemented locally viastartSpan)SessionViewSemanticsrenamed toRumSessionViewflutterrific_otel.dart, barrel export*Resource/*Semanticstypes removed from API packageflutterrific_opentelemetry.dart)dartastic_opentelemetry_apiimports (now subsumed by SDK import)Test plan
flutter analyze --fatal-infos— no issuesflutter test— all 30 tests passOTelNavigatorObserverwith standardMaterialApp+Navigator.push()— confirmed working vianavigation_observer_test.dart(OTelNavigatorObserver with MaterialApp (non-GoRouter)group)Closes #15