Skip to content

add error messages when lacking permissions for commands #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZWORX52 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add error messages when lacking permissions for commands #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Gameserver/src/ffa/java/com/minecrafttas/tasbattle/ffa/managers/KitManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,11 @@ public void onClick(InventoryClickEvent e) {
*/
@Override
public boolean onCommand(CommandSender sender, @NotNull Command command, @NotNull String label, String[] args) {
if (!sender.isOp())
if (!sender.isOp()) {
sender.sendMessage(MiniMessage.miniMessage().deserialize("<aqua>»</aqua> <red>Insufficient permissions</red>"));
return true;

}

// print help
if (args.length == 0) {
sender.sendMessage(MiniMessage.miniMessage().deserialize("<aqua>»</aqua> <gray>/ffa <green>save <aqua>\\<name> \\<material> \\<description></aqua></green></gray>"));
Expand Down
3 changes: 2 additions & 1 deletion Gameserver/src/main/java/com/minecrafttas/tasbattle/TASBattleGameserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.papermc.paper.event.player.AsyncChatEvent;
import lombok.Getter;
import lombok.SneakyThrows;
import net.kyori.adventure.text.minimessage.MiniMessage;
import org.apache.commons.lang3.tuple.Pair;
import org.bukkit.Bukkit;
import org.bukkit.command.Command;
Expand Down Expand Up @@ -90,7 +91,7 @@ public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command
if (sender.isOp())
Runtime.getRuntime().halt(0);
else
sender.sendMessage(Bukkit.getServer().permissionMessage());
sender.sendMessage(MiniMessage.miniMessage().deserialize("<aqua>»</aqua> <red>Insufficient permissions</red>"));

return true;
}
Expand Down
4 changes: 3 additions & 1 deletion Gameserver/src/main/java/com/minecrafttas/tasbattle/managers/TickrateChanger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,10 @@ public void onPluginMessageReceived(@NotNull String channel, Player player, byte
*/
@Override
public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label, @NotNull String[] args) {
if (!sender.isOp() || args.length != 1)
if (!sender.isOp() || args.length != 1) {
sender.sendMessage(MiniMessage.miniMessage().deserialize("<aqua>»</aqua> <red>Insufficient permissions</red>"));
return true;
}

try {
// parse and update tickrate
Expand Down
4 changes: 3 additions & 1 deletion Lobby/src/main/java/com/minecrafttas/tasbattle/managers/TickrateChanger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,10 @@ public void onPluginMessageReceived(@NotNull String channel, Player player, byte
*/
@Override
public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command, @NotNull String label, @NotNull String[] args) {
if (!sender.isOp() || args.length != 1)
if (!sender.isOp() || args.length != 1) {
sender.sendMessage(MiniMessage.miniMessage().deserialize("<aqua>»</aqua> <red>Insufficient permissions</red>"));
return true;
}

try {
// parse and update tickrate
Expand Down