Conversation
VaiTon
reviewed
May 6, 2019
Contributor
VaiTon
left a comment
VaiTon
left a comment
There was a problem hiding this comment.
I don't think upgrading to 1.14 right now is a good idea because of the instability of the bukkit API.
| <version>3.8.0</version> | ||
| <configuration> | ||
| <source>1.8</source> | ||
| <source>1.8</source> |
Contributor
Author
There was a problem hiding this comment.
Messed up formatting it seems, not sure. Any ideas for the freestanding signs?
1.14 works well so far, since i'm running it on 1.14 and the very long deprecated getData() methods are now finally removed. So it needs to be changed for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update to mc 1.14 and fix deprecated sign api, since metadata of material sign is gone
note: i didn't add support for a sign checking the block below, since wallsign and freestanding signs are now different implementations