Update dependencies; explicitly set UTF-8 encoding#29
Open
itsTyrion wants to merge 1 commit intoMinecrell:masterfrom
Open
Update dependencies; explicitly set UTF-8 encoding#29itsTyrion wants to merge 1 commit intoMinecrell:masterfrom
itsTyrion wants to merge 1 commit intoMinecrell:masterfrom
Conversation
Author
|
One more thing: I spent about an hour turning in circles because I didn't know that the Log4j2 plugin cache (Log4j2Plugins.dat) needs to be merged, I was unable to get it to work without it (aside from the deprecated For Gradle, there's a transformer in shadow shadowJar {
transform(com.github.jengelman.gradle.plugins.shadow.transformers.Log4j2PluginsCacheFileTransformer)
}For maven, Apache took over what used to be a 3rd party plugin: https://logging.apache.org/log4j/transform/latest/#log4j-plugin-cache-transformer Should I add that a hint about it to the README? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did a quick test, everything seems to work so far.
explicitly set UTF-8 encoding because I was getting an "illegal character" error at the section symbol (§) during build.
The Log4J2 version in HEAD/master is vulnerable to Log4shell btw !!