Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed commit hashes in your benchmark.
Please check my modification.
I explain details of reason to fix commit hashes below.
Wrong Commit Hashes
I found #009022987 in ACCUMULO.csv (line 23) and #187838022 in LUCENE.csv (line 24) are wrong commit hashes.
I think #9022987e0 and #0187838022 are the correct commit hashes for accumulo and lucene-solr respectively.
So I fixed these commit hashes.
Duplication of Commit Hashes and Issue
I found #70a5ffe4 is duplicated in OOZIE.csv (line 17).
And I found HADOOP-9563(line 9 and line 50) and HADOOP-13189(line 32 and line53) are duplicated in HADOOP.csv.
So I removed the duplicated commit hash and issue.
Wrong Bug Induce Commit
I think #e28edbffe15 is not bug inducing commit of HADOOP-9405(line 8).
According to Bug report of HADOOP-9405, the bug is introduced by HADOOP-9252.
But #e28edbffe15 looks the commit for HDFS-4468.
I think #ef2ff99d367 is the commit for HADOOP-9252.
So, I replaced #e28edbffe15 with #ef2ff99d367.