core_complex: set NONE finish condition#42
Merged
eyck merged 1 commit intoMinres:mainfrom Feb 10, 2026
Merged
Conversation
Contributor
|
Using a cci_param is my preferred solution for this. Implementing a converter would even allow to specify them literally. |
eugenecohen-qti
force-pushed
the
never_finish
branch
from
3068cfb to
3df5ea8
Compare
Author
|
I couldn't change the title of the PR but replaced the commit with the CCI var implementation |
Author
|
@eyck ready for review |
eyck
requested changes
Feb 10, 2026
src/sysc/core_complex.h
Outdated
| } | ||
| template <typename U = QK> typename std::enable_if<std::is_same<U, tlm::scc::quantumkeeper_st>::value>::type run_iss() { | ||
| vm->start(std::numeric_limits<uint64_t>::max(), dump_ir); | ||
| template <typename U = QK> typename std::enable_if<std::is_same<U, tlm::scc::quantumkeeper>::value>::type run_iss() { |
Contributor
There was a problem hiding this comment.
Pls keep the single threaded quantum_keeper (quantum_keeper_st) as quantum_keeper is a transitional alias.
Author
There was a problem hiding this comment.
@eyck apologies - this was an artifact of my cherry-pick from an older revision, updated now
Contributor
There was a problem hiding this comment.
No prob since it's not critical...
Add CCI variable to hold the finish condition enumeration value and apply it to the ISS.
eugenecohen-qti
force-pushed
the
never_finish
branch
from
3df5ea8 to
80a4ebb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eyck we need some way to specify a finish condition of NONE. This PR is just a brute-force solution which I presume doesn't work for all use cases. What would you like to do here? We could define a CCI variable (or multiple) if that would be better.