GEOPY-2657: Allow UIJson forms to accept geoh5py.Entity#866
Merged
domfournier merged 12 commits intodevelopfrom Mar 31, 2026
Merged
GEOPY-2657: Allow UIJson forms to accept geoh5py.Entity#866domfournier merged 12 commits intodevelopfrom
domfournier merged 12 commits intodevelopfrom
Conversation
github-actions
bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the UI JSON form validation/annotation layer so form fields that represent UUIDs can accept Entity instances (and lists of entities) and be automatically converted to UUIDs, with accompanying test updates.
Changes:
- Added an
entity_to_uuidvalidator to demoteEntityinputs to their.uid. - Moved several Pydantic
Annotatedaliases (e.g.,MeshTypes,GroupTypes,OptionalUUID*,PathList) intogeoh5py/ui_json/annotations.pyand updated imports accordingly. - Extended tests to cover passing
ObjectForm.valueas an entity andMultiSelectDataForm.valueas a list of data entities.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/ui_json/forms_test.py |
Adds coverage for entity/list-of-entity inputs to form value fields. |
geoh5py/ui_json/validations/form.py |
Introduces entity_to_uuid and refactors UUID serialization helpers. |
geoh5py/ui_json/forms.py |
Switches form type aliases to centralized ui_json.annotations and keeps enums local. |
geoh5py/ui_json/annotations.py |
Centralizes shared Annotated aliases and wires in entity_to_uuid as a BeforeValidator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #866 +/- ##
===========================================
+ Coverage 91.13% 91.20% +0.07%
===========================================
Files 115 112 -3
Lines 10353 10338 -15
Branches 1915 1911 -4
===========================================
- Hits 9435 9429 -6
+ Misses 491 481 -10
- Partials 427 428 +1
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
MatthieuCMira
requested changes
Mar 30, 2026
Contributor
MatthieuCMira
left a comment
MatthieuCMira
left a comment
There was a problem hiding this comment.
I have the feeling things could be simpler and have a better organization
# Conflicts: # geoh5py/ui_json/annotations.py # geoh5py/ui_json/forms.py # geoh5py/ui_json/validations/form.py
…tion # Conflicts: # geoh5py/shared/utils.py # geoh5py/ui_json/annotations.py # geoh5py/ui_json/forms.py # geoh5py/ui_json/ui_json.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2657 - Allow UIJson forms to accept geoh5py.Entity