Skip to content

GEOPY-2762: Add mechanisms to update the UIJson class with values#868

Merged
domfournier merged 12 commits intodevelopfrom
GEOPY-2762
Mar 31, 2026
Merged

GEOPY-2762: Add mechanisms to update the UIJson class with values#868
domfournier merged 12 commits intodevelopfrom
GEOPY-2762

Conversation

@domfournier
Copy link
Copy Markdown
Contributor

@domfournier domfournier commented Mar 30, 2026

GEOPY-2762 - Add mechanisms to update the UIJson class with values

@github-actions github-actions bot changed the title GEOPY-2762 GEOPY-2762: Add mechanisms to update the UIJson class with values Mar 30, 2026
# Conflicts:
#	geoh5py/ui_json/ui_json.py
#	geoh5py/ui_json/validations/form.py
Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only major comment is the set_value of dataorvalue form

Base automatically changed from GEOPY-2657 to develop March 31, 2026 17:36
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (2f2e5e7) to head (7f4cee7).
⚠️ Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #868   +/-   ##
========================================
  Coverage    91.25%   91.25%           
========================================
  Files          112      112           
  Lines        10338    10343    +5     
  Branches      1911     1908    -3     
========================================
+ Hits          9434     9439    +5     
  Misses         477      477           
  Partials       427      427           
Files with missing lines Coverage Δ
geoh5py/ui_json/annotations.py 100.00% <100.00%> (ø)
geoh5py/ui_json/forms.py 95.25% <100.00%> (+0.27%) ⬆️
geoh5py/ui_json/ui_json.py 89.50% <100.00%> (-0.66%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier
Copy link
Copy Markdown
Contributor Author

@copilot

Copilot AI review requested due to automatic review settings March 31, 2026 17:53
@domfournier domfournier review requested due to automatic review settings March 31, 2026 17:53
Copilot AI review requested due to automatic review settings March 31, 2026 17:55
@domfournier domfournier review requested due to automatic review settings March 31, 2026 17:55
Copy link
Copy Markdown
Contributor

@MatthieuCMira MatthieuCMira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good for me!

@domfournier domfournier merged commit 9f14d21 into develop Mar 31, 2026
20 checks passed
@domfournier domfournier deleted the GEOPY-2762 branch March 31, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants