Optimizing and clean up. - #50
Closed
Lumitani-pixel wants to merge 6 commits into
Closed
Conversation
Owner
|
Log4J dependency is not needed, you can look at https://docs.fabricmc.net/develop/debugging |
MiranCZ
requested changes
Oct 10, 2025
MiranCZ
left a comment
MiranCZ
left a comment
Owner
There was a problem hiding this comment.
Left some comments.
I would generally be cautious making these big "cleanup" changes because its easy to get wrong, but the logic seems correct.
| case OVERWORLD, NETHER -> { | ||
| if (timer.getDuration() >= 30) { | ||
| } | ||
| if (timer.getDuration() >= 30) {} |
Owner
There was a problem hiding this comment.
Here I think the newline was better
| * - Directional bias to reduce ping-pong movement | ||
| * - BFS-style neighbor expansion for spatial continuity | ||
| * - Caching of chunk search results | ||
| * - Optional parallel scanning (lightweight) |
Owner
There was a problem hiding this comment.
This whole commit looks very AI generated. I am not merging obvious AI slop.
| targetSlot.ifPresent(slot -> mod.getSlotHandler().clickSlot(slot, 0, SlotActionType.PICKUP)); | ||
| } | ||
|
|
||
| // Release all held inputs and resume automation |
Contributor
Author
|
made a new commit where i fixed the problems with the last ones |
Contributor
Author
|
Could you pls review my new commit to check if everything is fine now. I removed and added everything in the change request. |
Contributor
Author
|
Almost a month So I dont think there is much happening anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I optimized the killaura and cleaned it up and I did the same for the ChunkSearchTasks.
I also did a light cleanup in some files. (no breaking changes and no method removal)
Information
Checklist