Update to work with mps, tested on M5 Max - #18
Open
taxilian wants to merge 2 commits into
Open
Conversation
Author
|
Update: while this does work, it doesn't seem to keep a consistent voice between sentences and I can't figure out why. I think there is likely a bug somewhere further in than the code in this repository, but I don't understand the infrastructure well enough to be sure. If I use cpu inference it works, but using mps a cloned voice works only for the first sentence and then changes voices (entirely changes the voice, not just some drift) to an apparently random voice each sentence thereafter. |
Contributor
|
Hey @taxilian, thanks so much for helping with this. I'll have a look and try to see what the issue is. |
Author
|
With that fix I'm not having the issue with it changing voices anymore; it does take it to a float32, though, not sure what impact that has on anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this is the best way to do all of this, but it's working for me! Fixes #1