fix: gracefully truncate context on long conversations - #32
Open
ArvindShah wants to merge 1 commit into
Open
Conversation
…tions Previously, generate() concatenated all context segments unconditionally and raised a ValueError only after all tokenization was complete. For multi-turn conversations this made the function unpredictably crash once the accumulated frames exceeded the 2048 limit. Now the method uses a sliding-window strategy: it computes the frame budget upfront, then drops the oldest segments until the context fits. A warnings.warn() is emitted when segments are dropped so callers can detect and handle the truncation without catching exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate()concatenates all context segments unconditionally, then raises aValueErroronly after tokenization is complete. For multi-turn conversations this causes unpredictable crashes once the accumulated frames exceed the 2048 limit.warnings.warn()when segments are dropped, so callers can detect and handle the truncation without catching exceptions.Changes
Test plan
python run_misotts.pywith the default 4-turn conversation (fits within context — no truncation, same output as before)UserWarningis emitted and audio still generates correctlytextstring that exceeds the budget on its own — verify a clearValueErroris raised with an actionable message