parse GIT_CONFIG_PARAMETERS#979
Draft
pickx wants to merge 4 commits into
Draft
Conversation
pickx
force-pushed
the
pickx/git-config-from-var
branch
2 times, most recently
from
fb7e660 to
fb3bed8
Compare
pickx
commented
Jun 15, 2025
| /// will also be an empty string. | ||
| /// 4. an empty string will later be interpreted as `true`, | ||
| /// but we don't do this here. | ||
| pub(crate) fn parse_git_config_parameters(env_var: OsString) -> Vec<(String, String)> { |
Author
There was a problem hiding this comment.
rather than do this here, passing the (key, value) pairs along until they are consumed and parsed by ConfigLoader, we can read the env directly in ConfigLoader (since that reads the environment to get the repository, etc., so it is already impure).
the advantage (?) of doing this here is that we treat the -cs like the CLI args that they are.
I have no strong opinion regarding which solution is better
pickx
force-pushed
the
pickx/git-config-from-var
branch
from
fb3bed8 to
fb7e660
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #977 .
also contains a drive by refactor: a somewhat nicer way to parse
Argsfrom strings (especially in tests).once again, if this is unnecessary, unwarranted or should just be split out to a smaller PR, that's no problem.
still a draft because of two potential issues:
git?GIT_CONFIG_PARAMETERSenv var (despite the title of this PR), just the value that we expectgitto leave there after usinggit -c. I suspect that we can't assume that it's properly escaped. that said, do we even care about use cases other than setting it viagit -c?