Added Serilog ILogger.Debug for logging the HTTP Responses#69
Open
anh-duc-le wants to merge 12 commits intoMitjaBezensek:masterfrom
Open
Added Serilog ILogger.Debug for logging the HTTP Responses#69anh-duc-le wants to merge 12 commits intoMitjaBezensek:masterfrom
anh-duc-le wants to merge 12 commits intoMitjaBezensek:masterfrom
Conversation
added 12 commits
April 25, 2018 14:49
DeleteRepository returns HttpStatusCode instead of Repository.
* Added PostBranch * Added ListBranch
UserEndPoint: Added GetEmails POCOS : + Added Email/ Group/ LinkConfigurations/ Member/ Project/ ProjectPostParams + Modified Branch / Branchrestriction / Repository / User
This reverts commit dfcb474.
public string slug { get; set; }
Collaborator
|
It seems that you have implemented new endpoints and resources for the V2 API which is appreciated Can you clean up your pull request to just the support of the new endpoints and resources ? |
Contributor
|
Take a look at https://github.com/damianh/LibLog you are not depending on one particular logging framework then |
Collaborator
|
I didn't know liblog but it seems effectively a interesting solution to not expose dependency to a specific logging framework but it's not done with that lib yet in that pull request, and I would prefer to validate separate pull requests, one for adding a log support, and one for adding support of new endpoints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestExecutor.cs
Sharpbucket.cs
EndPoint.cs
repositoriesEndPoint
Repository Resource
TeamEndPoin : Added PostProject/ ListProjects / GetProject …
UserEndPoint: Added GetEmails
POCOS :